Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I make a pull request? #11

Open
ghost opened this issue Dec 28, 2015 · 2 comments
Open

Can I make a pull request? #11

ghost opened this issue Dec 28, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 28, 2015

I've made some changes to your repo to:

  1. make it more efficient readable (enforcing best practices, as shown here: https://github.com/johnpapa/angular-styleguide),
  2. allow it to be minified without being broken and
  3. added a minified version (someone asked for one in another issue).

If I could push my branch for a review that'd be great. Everything works exactly the same but allows for more flexibility now. Just waiting on your permission to push my new branch (pulled from master).

@apparentlymart
Copy link
Owner

Sure, please do!

I don't think generated files belong under version control so I wouldn't include the minified version (making that is the responsibility of the user of this library, so they can bundle it with the rest of their code) but I'd definitely accept the other changes.

@ghost
Copy link
Author

ghost commented Dec 28, 2015

Ah so changing the structure wouldn't apply then would it?

For example, one of the changes was separating the two directives into
separate files and including them in a single module (the viewhead module).

On Monday, December 28, 2015, Martin Atkins [email protected]
wrote:

Sure, please do!

I don't think generated files belong under version control so I wouldn't
include the minified version (making that is the responsibility of the user
of this library, so they can bundle it with the rest of their code) but I'd
definitely accept the other changes.


Reply to this email directly or view it on GitHub
#11 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant