-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koa-bodyparser seems dead now; @koa/bodyparser is the up-to-date version #214
Comments
Another issue related to this: going from v4 ( Makes sense since GET requests have no body, so should need no parsing. But this Apollo Koa integration still indiscriminately expects a apollo-server-integration-koa/src/index.ts Lines 72 to 82 in 71b7ba3
I'm hackily setting |
Hi @aseemk, please refer to this previous comment: #60 (comment) Ultimately I agree It is certainly a good idea to use packages that are actively maintained, if you feel strongly I definitely encourage a PR with the changes. |
Hi there. Thanks for this library! We've been using it and it's helpful.
I recently ran into an issue unrelated to Apollo, but related to the Koa body-parsing middleware this library expects and requires.
We installed
koa-bodyparser
which this library's readme recommends. However, you can see that package is stuck on version 4.If you go to the Koa bodyparser's GitHub repo, it actually specifies the package name as
@koa/bodyparser
— and that package is on version 5 now (and actually maintained).I had to use a new option added to version 5 to fix a bug, and couldn't understand why there was no version 5 on npm.
Please consider upgrading not just the readme here but also the code and test dependencies on this package.
Thanks again and hope this helps others!
The text was updated successfully, but these errors were encountered: