Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine/de-duplicate turkic.tsv #132

Open
jonorthwash opened this issue Mar 25, 2019 · 5 comments
Open

Combine/de-duplicate turkic.tsv #132

jonorthwash opened this issue Mar 25, 2019 · 5 comments

Comments

@jonorthwash
Copy link
Member

jonorthwash commented Mar 25, 2019

Some language name overrides are not being honored. E.g., beta.apertium.org and turkic.apertium.org both show "Tuvinian" in English for tyv despite the presence of "Tuvan" as an override.

Also, I don't understand why some Turkic-language overrides are in turkic.sql and some are in manual.sql. Is this intentional?

@sushain97
Copy link
Member

Also, I don't understand why some Turkic-language overrides are in turkic.sql and some are in manual.sql. Is this intentional?

Probably an artifact of pre-split.

Your first question looks like a bug though. Will investigate.

@sushain97
Copy link
Member

I think turkic.sql is a file you created with a subset of the other language names just for turkic.apertium.org? I can't really recall exactly what the intent was.

Regardless, it has a bunch of duplication with the other files and is not actually used in the language names DB compilation:

cat language_names/scraped.sql language_names/scraped-sil.sql language_names/manual.sql language_names/variants.sql | sqlite3 langNames.db

@jonorthwash
Copy link
Member Author

I think originally turkic.sql was the only overrides. Perhaps we should move the non-duplicated stuff to the main overrides file and get rid of turkic.sql?

@sushain97
Copy link
Member

Good plan. After #131 gets merged, it can be taken care of.

@sushain97 sushain97 changed the title not all language names being incorporated Combine turkic.sql Mar 26, 2019
@jonorthwash
Copy link
Member Author

Oh, I thought we'd talked about this before. Indeed we have.

@sushain97 sushain97 changed the title Combine turkic.sql Combine/de-duplicate turkic.tsv Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants