chore(client): json util supply method to parse json list #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
diaohancai
changed the title
imbajin
reviewed
Feb 7, 2024
Comment on lines
+66
to
+76
| public static <T> List<T> fromJson2List(String json, Class<T> clazz) { | ||
| try { | ||
| return MAPPER.readValue(json, getCollectionType(List.class, clazz)); | ||
| } catch (IOException e) { | ||
| throw new SerializeException("Failed to deserialize json '%s'", e, json); | ||
| } | ||
| } | ||
|
|
||
| private static JavaType getCollectionType(Class<?> collectionClass, | ||
| Class<?>... elementClasses) { | ||
| return MAPPER.getTypeFactory().constructParametricType(collectionClass, elementClasses); |
There was a problem hiding this comment.
shall we consider moving the JsonUtil to hugegraph-common module?
license header (add we'll provide a doc to setup IDEA soon) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
============================================
+ Coverage 62.49% 62.54% +0.04%
- Complexity 1903 1925 +22
============================================
Files 262 267 +5
Lines 9541 9681 +140
Branches 886 888 +2
============================================
+ Hits 5963 6055 +92
- Misses 3190 3237 +47
- Partials 388 389 +1 ☔ View full report in Codecov by Sentry. |
javeme
reviewed
Feb 24, 2024
| @@ -60,4 +62,17 @@ public static <T> T convertValue(JsonNode node, Class<T> clazz) { | |||
| e, node); | |||
| } | |||
| } | |||
|
|
|||
| public static <T> List<T> fromJson2List(String json, Class<T> clazz) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
org.apache.hugegraph.util.JsonUtilsupply method to parse json list.Verifying these changes
org.apache.hugegraph.unit.JsonUtilTestDoes this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need