Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44455: [C++] Update vendored date to 3.0.3 #44482

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 21, 2024

Rationale for this change

IANA tzdata changed its data format. So we need to update vendored date to parse it.

What changes are included in this PR?

Update vendored date to 3.0.3.

Update script is added. So all our changes are automated now.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Copy link

⚠️ GitHub issue #44455 has been automatically assigned in GitHub to PR creator.

IANA tzdata changed its data format. So we need to update vendored
date to parse it.
Copy link
Member Author

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou kou merged commit 67850be into apache:main Oct 23, 2024
40 checks passed
@kou kou deleted the cpp-vendored-date-3.0.3 branch October 23, 2024 00:15
@kou kou removed the awaiting committer review Awaiting committer review label Oct 23, 2024
@github-actions github-actions bot added the awaiting changes Awaiting changes label Oct 23, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 67850be.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant