-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44079: [C++][Parquet] Remove deprecated APIs #44080
Conversation
848c9c4
to
0671d9a
Compare
cc @emkornfield |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for me
0671d9a
to
9eff241
Compare
Rebased, will wait for CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I'm kind of new to parquet codebase, the change looks good enough to me. +1.
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 990cdf7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 220 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### What changes are included in this PR? Remove APIs that have been deprecated more than one year ago (i.e. in 2023 or before). * GitHub Issue: apache#44079 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
What changes are included in this PR?
Remove APIs that have been deprecated more than one year ago (i.e. in 2023 or before).