Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44079: [C++][Parquet] Remove deprecated APIs #44080

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 12, 2024

What changes are included in this PR?

Remove APIs that have been deprecated more than one year ago (i.e. in 2023 or before).

@mapleFU
Copy link
Member

mapleFU commented Sep 12, 2024

cc @emkornfield

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for me

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 12, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 12, 2024

Rebased, will wait for CI

Copy link
Collaborator

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm kind of new to parquet codebase, the change looks good enough to me. +1.

@pitrou pitrou merged commit 990cdf7 into apache:main Sep 12, 2024
35 of 36 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Sep 12, 2024
@pitrou pitrou deleted the gh44079-pq-deprecated-apis branch September 12, 2024 17:42
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 990cdf7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 220 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
### What changes are included in this PR?

Remove APIs that have been deprecated more than one year ago (i.e. in 2023 or before).

* GitHub Issue: apache#44079

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants