Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Implement cast suggestions for all nested types in Concatenate #43316

Open
felipecrv opened this issue Jul 18, 2024 · 5 comments
Open

[C++] Implement cast suggestions for all nested types in Concatenate #43316

felipecrv opened this issue Jul 18, 2024 · 5 comments

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

#43190 improves error messages in case of offset overflow when string/binary/list arrays are being concatenated. These values can live inside nested types (e.g. struct), so when concatenating a type like struct<a: int8, b: list> an overflow on the recursive concatenation of field b should lead to a cast suggestion to struct<a: int8, b: large_list>.

Component(s)

C++

@sunby
Copy link

sunby commented Jul 18, 2024

I would like to take a try.

@sunby
Copy link

sunby commented Jul 18, 2024

take

@felipecrv
Copy link
Contributor Author

@sunby don't try to fix them all before opening a PR for review. Take a look at how it was done for lists in he PR linked above.

@sunby
Copy link

sunby commented Jul 19, 2024

@sunby don't try to fix them all before opening a PR for review. Take a look at how it was done for lists in he PR linked above.

thanks for the advice! I plan to split them into several PRs and start from the struct type.

@laksh-krishna-sharma
Copy link

May I work on this issue with a little bit of your guidance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants