Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Move TakeXXX free functions into TakeMetaFunction and make them private #42126

Closed
felipecrv opened this issue Jun 12, 2024 · 1 comment
Closed

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

In the PR that makes "array_take" handle chunked arrays more efficiently (#41700) I do many changes to the dispatching logic in the TakeMetaFunction, including the move of all these functions into the class scope.

This issue is about that code-move step, so I can reduce the noise in #41700.

Component(s)

C++

felipecrv added a commit that referenced this issue Jun 13, 2024
… make them private (#42127)

### Rationale for this change

Move TakeXXX free functions into `TakeMetaFunction` and make them private

### What changes are included in this PR?

Code move and some small refactorings in preparation for #41700.

### Are these changes tested?

By existing tests.
* GitHub Issue: #42126

Authored-by: Felipe Oliveira Carvalho <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
@felipecrv felipecrv added this to the 17.0.0 milestone Jun 13, 2024
@felipecrv
Copy link
Contributor Author

Issue resolved by pull request 42127
#42127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant