From 3c00b08046be6549cc05714959ddcb993051ac45 Mon Sep 17 00:00:00 2001 From: Kuba Martin Date: Mon, 7 Aug 2023 18:27:26 +0200 Subject: [PATCH] GH-36936: [Go] Make it possible to register custom functions. (#36959) ### Rationale for this change As discussed in the issue #36936 , this change makes it possible for the consumers of the module to register custom functions, while taking advantage of the existing infrastructure for matching types and choosing kernels. ### What changes are included in this PR? Just moving the package one level higher, so that it's module-exported. ### Are these changes tested? There's no actual code changes other than moving files around and updating imports - existing tests still pass. ### Are there any user-facing changes? The `compute/exec` is now exported. * Closes: #36936 Authored-by: Jakub Martin Signed-off-by: Matt Topol --- go/arrow/compute/arithmetic.go | 2 +- go/arrow/compute/arithmetic_test.go | 2 +- go/arrow/compute/cast.go | 2 +- go/arrow/compute/example_test.go | 91 +++++++++++++++++++ go/arrow/compute/exec.go | 2 +- .../compute/{internal => }/exec/hash_util.go | 0 .../compute/{internal => }/exec/kernel.go | 0 .../{internal => }/exec/kernel_test.go | 2 +- go/arrow/compute/{internal => }/exec/span.go | 0 .../compute/{internal => }/exec/span_test.go | 2 +- go/arrow/compute/{internal => }/exec/utils.go | 0 .../compute/{internal => }/exec/utils_test.go | 2 +- go/arrow/compute/exec_internals_test.go | 2 +- go/arrow/compute/exec_test.go | 2 +- go/arrow/compute/executor.go | 2 +- go/arrow/compute/expression.go | 2 +- go/arrow/compute/exprs/exec.go | 2 +- go/arrow/compute/functions.go | 2 +- .../internal/kernels/base_arithmetic.go | 2 +- .../internal/kernels/base_arithmetic_amd64.go | 2 +- .../kernels/basic_arithmetic_noasm.go | 2 +- .../compute/internal/kernels/boolean_cast.go | 2 +- go/arrow/compute/internal/kernels/cast.go | 2 +- .../compute/internal/kernels/cast_temporal.go | 2 +- go/arrow/compute/internal/kernels/helpers.go | 2 +- .../compute/internal/kernels/numeric_cast.go | 2 +- go/arrow/compute/internal/kernels/rounding.go | 2 +- .../internal/kernels/scalar_arithmetic.go | 2 +- .../internal/kernels/scalar_boolean.go | 2 +- .../kernels/scalar_comparison_amd64.go | 2 +- .../kernels/scalar_comparison_noasm.go | 2 +- .../internal/kernels/scalar_comparisons.go | 2 +- .../compute/internal/kernels/string_casts.go | 2 +- go/arrow/compute/internal/kernels/types.go | 2 +- .../compute/internal/kernels/vector_hash.go | 2 +- .../internal/kernels/vector_run_end_encode.go | 2 +- .../internal/kernels/vector_selection.go | 2 +- go/arrow/compute/registry_test.go | 2 +- go/arrow/compute/scalar_bool.go | 2 +- go/arrow/compute/scalar_compare.go | 2 +- go/arrow/compute/scalar_compare_test.go | 2 +- go/arrow/compute/selection.go | 2 +- go/arrow/compute/utils.go | 2 +- go/arrow/compute/vector_hash_test.go | 2 +- go/arrow/compute/vector_run_end_test.go | 2 +- go/arrow/compute/vector_selection_test.go | 2 +- 46 files changed, 132 insertions(+), 41 deletions(-) create mode 100644 go/arrow/compute/example_test.go rename go/arrow/compute/{internal => }/exec/hash_util.go (100%) rename go/arrow/compute/{internal => }/exec/kernel.go (100%) rename go/arrow/compute/{internal => }/exec/kernel_test.go (99%) rename go/arrow/compute/{internal => }/exec/span.go (100%) rename go/arrow/compute/{internal => }/exec/span_test.go (99%) rename go/arrow/compute/{internal => }/exec/utils.go (100%) rename go/arrow/compute/{internal => }/exec/utils_test.go (98%) diff --git a/go/arrow/compute/arithmetic.go b/go/arrow/compute/arithmetic.go index 2df547e5b4fa4..046cb3f2d9e13 100644 --- a/go/arrow/compute/arithmetic.go +++ b/go/arrow/compute/arithmetic.go @@ -23,7 +23,7 @@ import ( "fmt" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" diff --git a/go/arrow/compute/arithmetic_test.go b/go/arrow/compute/arithmetic_test.go index c4e0c591cbf54..d9dd799b7cfce 100644 --- a/go/arrow/compute/arithmetic_test.go +++ b/go/arrow/compute/arithmetic_test.go @@ -29,7 +29,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" diff --git a/go/arrow/compute/cast.go b/go/arrow/compute/cast.go index aad07413bf3ff..d77273f539595 100644 --- a/go/arrow/compute/cast.go +++ b/go/arrow/compute/cast.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" ) diff --git a/go/arrow/compute/example_test.go b/go/arrow/compute/example_test.go new file mode 100644 index 0000000000000..8d0f25e4c4372 --- /dev/null +++ b/go/arrow/compute/example_test.go @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +//go:build go1.18 + +package compute_test + +import ( + "context" + "fmt" + "log" + + "github.com/apache/arrow/go/v13/arrow" + "github.com/apache/arrow/go/v13/arrow/array" + "github.com/apache/arrow/go/v13/arrow/compute" + "github.com/apache/arrow/go/v13/arrow/compute/exec" + "github.com/apache/arrow/go/v13/arrow/memory" +) + +// This example demonstrates how to register a custom scalar function. +func Example_customFunction() { + pool := memory.NewGoAllocator() + + ctx := context.Background() + execCtx := compute.DefaultExecCtx() + ctx = compute.SetExecCtx(ctx, execCtx) + + add42 := compute.NewScalarFunction("add_42", compute.Arity{ + NArgs: 1, + }, compute.FunctionDoc{ + Summary: "Returns the input values plus 42", + ArgNames: []string{"input"}, + }) + + if err := add42.AddNewKernel( + []exec.InputType{ + // We accept a single argument (array) of Int8 type. + { + Kind: exec.InputExact, + Type: arrow.PrimitiveTypes.Int8, + }, + }, + // We'll return a single Int8 array. + exec.NewOutputType(arrow.PrimitiveTypes.Int8), + func(ctx *exec.KernelCtx, span *exec.ExecSpan, result *exec.ExecResult) error { + // The second buffer contains the values. Both for the input and the output arrays. + for i, x := range span.Values[0].Array.Buffers[1].Buf { + result.Buffers[1].Buf[i] = x + 42 + } + return nil + }, + nil, + ); err != nil { + log.Fatal(err) + } + execCtx.Registry.AddFunction(add42, true) + + inputArrayBuilder := array.NewInt8Builder(pool) + for i := 0; i < 16; i++ { + inputArrayBuilder.Append(int8(i)) + } + inputArray := inputArrayBuilder.NewArray() + + outputArrayDatum, err := compute.CallFunction( + compute.SetExecCtx(context.Background(), execCtx), + "add_42", + nil, + &compute.ArrayDatum{Value: inputArray.Data()}, + ) + if err != nil { + log.Fatal(err) + } + + fmt.Println(array.NewInt8Data(outputArrayDatum.(*compute.ArrayDatum).Value).Int8Values()) + + // Output: + // [42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57] +} diff --git a/go/arrow/compute/exec.go b/go/arrow/compute/exec.go index 6dbef8cdfbbd9..c478a1dcdef7d 100644 --- a/go/arrow/compute/exec.go +++ b/go/arrow/compute/exec.go @@ -23,7 +23,7 @@ import ( "fmt" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" ) diff --git a/go/arrow/compute/internal/exec/hash_util.go b/go/arrow/compute/exec/hash_util.go similarity index 100% rename from go/arrow/compute/internal/exec/hash_util.go rename to go/arrow/compute/exec/hash_util.go diff --git a/go/arrow/compute/internal/exec/kernel.go b/go/arrow/compute/exec/kernel.go similarity index 100% rename from go/arrow/compute/internal/exec/kernel.go rename to go/arrow/compute/exec/kernel.go diff --git a/go/arrow/compute/internal/exec/kernel_test.go b/go/arrow/compute/exec/kernel_test.go similarity index 99% rename from go/arrow/compute/internal/exec/kernel_test.go rename to go/arrow/compute/exec/kernel_test.go index 827ac97e63a01..65fc41e4e4d56 100644 --- a/go/arrow/compute/internal/exec/kernel_test.go +++ b/go/arrow/compute/exec/kernel_test.go @@ -25,7 +25,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/apache/arrow/go/v13/arrow/scalar" "github.com/stretchr/testify/assert" diff --git a/go/arrow/compute/internal/exec/span.go b/go/arrow/compute/exec/span.go similarity index 100% rename from go/arrow/compute/internal/exec/span.go rename to go/arrow/compute/exec/span.go diff --git a/go/arrow/compute/internal/exec/span_test.go b/go/arrow/compute/exec/span_test.go similarity index 99% rename from go/arrow/compute/internal/exec/span_test.go rename to go/arrow/compute/exec/span_test.go index 2423824bbe5a7..3cbd54f0d4094 100644 --- a/go/arrow/compute/internal/exec/span_test.go +++ b/go/arrow/compute/exec/span_test.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/endian" "github.com/apache/arrow/go/v13/arrow/memory" diff --git a/go/arrow/compute/internal/exec/utils.go b/go/arrow/compute/exec/utils.go similarity index 100% rename from go/arrow/compute/internal/exec/utils.go rename to go/arrow/compute/exec/utils.go diff --git a/go/arrow/compute/internal/exec/utils_test.go b/go/arrow/compute/exec/utils_test.go similarity index 98% rename from go/arrow/compute/internal/exec/utils_test.go rename to go/arrow/compute/exec/utils_test.go index 40b98b26e7d1e..4f908bb2057b1 100644 --- a/go/arrow/compute/internal/exec/utils_test.go +++ b/go/arrow/compute/exec/utils_test.go @@ -23,7 +23,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/stretchr/testify/assert" ) diff --git a/go/arrow/compute/exec_internals_test.go b/go/arrow/compute/exec_internals_test.go index 4d259aa27394a..3247becd969a3 100644 --- a/go/arrow/compute/exec_internals_test.go +++ b/go/arrow/compute/exec_internals_test.go @@ -27,7 +27,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/testing/gen" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/apache/arrow/go/v13/arrow/scalar" diff --git a/go/arrow/compute/exec_test.go b/go/arrow/compute/exec_test.go index fb97c3c803f6b..308e30aac7316 100644 --- a/go/arrow/compute/exec_test.go +++ b/go/arrow/compute/exec_test.go @@ -25,7 +25,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/scalar" "github.com/stretchr/testify/suite" diff --git a/go/arrow/compute/executor.go b/go/arrow/compute/executor.go index d3f1a1fd41d4c..962f41019dac2 100644 --- a/go/arrow/compute/executor.go +++ b/go/arrow/compute/executor.go @@ -28,7 +28,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/memory" diff --git a/go/arrow/compute/expression.go b/go/arrow/compute/expression.go index b01c3b67133ad..04128bef7738c 100644 --- a/go/arrow/compute/expression.go +++ b/go/arrow/compute/expression.go @@ -30,7 +30,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/ipc" diff --git a/go/arrow/compute/exprs/exec.go b/go/arrow/compute/exprs/exec.go index 97b16ede11464..7683587478bf2 100644 --- a/go/arrow/compute/exprs/exec.go +++ b/go/arrow/compute/exprs/exec.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/endian" "github.com/apache/arrow/go/v13/arrow/internal/debug" diff --git a/go/arrow/compute/functions.go b/go/arrow/compute/functions.go index 3943fbca3597f..887346f7f5d06 100644 --- a/go/arrow/compute/functions.go +++ b/go/arrow/compute/functions.go @@ -24,7 +24,7 @@ import ( "strings" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" ) type Function interface { diff --git a/go/arrow/compute/internal/kernels/base_arithmetic.go b/go/arrow/compute/internal/kernels/base_arithmetic.go index 5da1b29a63dc8..bfdb7b8f2103e 100644 --- a/go/arrow/compute/internal/kernels/base_arithmetic.go +++ b/go/arrow/compute/internal/kernels/base_arithmetic.go @@ -25,7 +25,7 @@ import ( "github.com/JohnCGriffin/overflow" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/internal/debug" diff --git a/go/arrow/compute/internal/kernels/base_arithmetic_amd64.go b/go/arrow/compute/internal/kernels/base_arithmetic_amd64.go index 432acc3d81f8b..9683ac9420fdd 100644 --- a/go/arrow/compute/internal/kernels/base_arithmetic_amd64.go +++ b/go/arrow/compute/internal/kernels/base_arithmetic_amd64.go @@ -21,7 +21,7 @@ package kernels import ( "unsafe" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" "golang.org/x/exp/constraints" "golang.org/x/sys/cpu" diff --git a/go/arrow/compute/internal/kernels/basic_arithmetic_noasm.go b/go/arrow/compute/internal/kernels/basic_arithmetic_noasm.go index 1a2874df704f2..767425d61e221 100644 --- a/go/arrow/compute/internal/kernels/basic_arithmetic_noasm.go +++ b/go/arrow/compute/internal/kernels/basic_arithmetic_noasm.go @@ -19,7 +19,7 @@ package kernels import ( - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "golang.org/x/exp/constraints" ) diff --git a/go/arrow/compute/internal/kernels/boolean_cast.go b/go/arrow/compute/internal/kernels/boolean_cast.go index 7e1ff50c816df..b0ca7c2d9157a 100644 --- a/go/arrow/compute/internal/kernels/boolean_cast.go +++ b/go/arrow/compute/internal/kernels/boolean_cast.go @@ -24,7 +24,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" ) func isNonZero[T exec.FixedWidthTypes](ctx *exec.KernelCtx, in []T, out []byte) error { diff --git a/go/arrow/compute/internal/kernels/cast.go b/go/arrow/compute/internal/kernels/cast.go index 80be6ca15cc25..50cf775d2985e 100644 --- a/go/arrow/compute/internal/kernels/cast.go +++ b/go/arrow/compute/internal/kernels/cast.go @@ -21,7 +21,7 @@ package kernels import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" ) type CastOptions struct { diff --git a/go/arrow/compute/internal/kernels/cast_temporal.go b/go/arrow/compute/internal/kernels/cast_temporal.go index dbc92d2a3df0e..8201119a4edbc 100644 --- a/go/arrow/compute/internal/kernels/cast_temporal.go +++ b/go/arrow/compute/internal/kernels/cast_temporal.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" ) diff --git a/go/arrow/compute/internal/kernels/helpers.go b/go/arrow/compute/internal/kernels/helpers.go index fe91676f3bbc0..99816bc9bd43a 100644 --- a/go/arrow/compute/internal/kernels/helpers.go +++ b/go/arrow/compute/internal/kernels/helpers.go @@ -24,7 +24,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/apache/arrow/go/v13/arrow/scalar" diff --git a/go/arrow/compute/internal/kernels/numeric_cast.go b/go/arrow/compute/internal/kernels/numeric_cast.go index a7258f235418e..f0e469f15f338 100644 --- a/go/arrow/compute/internal/kernels/numeric_cast.go +++ b/go/arrow/compute/internal/kernels/numeric_cast.go @@ -25,7 +25,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/internal/debug" diff --git a/go/arrow/compute/internal/kernels/rounding.go b/go/arrow/compute/internal/kernels/rounding.go index ad385e4dce8e6..93f5829018f67 100644 --- a/go/arrow/compute/internal/kernels/rounding.go +++ b/go/arrow/compute/internal/kernels/rounding.go @@ -23,7 +23,7 @@ import ( "math" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/scalar" diff --git a/go/arrow/compute/internal/kernels/scalar_arithmetic.go b/go/arrow/compute/internal/kernels/scalar_arithmetic.go index 01622e0a4df94..3f6832cbbc583 100644 --- a/go/arrow/compute/internal/kernels/scalar_arithmetic.go +++ b/go/arrow/compute/internal/kernels/scalar_arithmetic.go @@ -24,7 +24,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/internal/debug" diff --git a/go/arrow/compute/internal/kernels/scalar_boolean.go b/go/arrow/compute/internal/kernels/scalar_boolean.go index 3c4916a1d94fe..59ea7627a204f 100644 --- a/go/arrow/compute/internal/kernels/scalar_boolean.go +++ b/go/arrow/compute/internal/kernels/scalar_boolean.go @@ -20,7 +20,7 @@ package kernels import ( "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/scalar" ) diff --git a/go/arrow/compute/internal/kernels/scalar_comparison_amd64.go b/go/arrow/compute/internal/kernels/scalar_comparison_amd64.go index 7d1db042cadae..a4cecb80bbd2f 100644 --- a/go/arrow/compute/internal/kernels/scalar_comparison_amd64.go +++ b/go/arrow/compute/internal/kernels/scalar_comparison_amd64.go @@ -22,7 +22,7 @@ import ( "unsafe" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "golang.org/x/sys/cpu" ) diff --git a/go/arrow/compute/internal/kernels/scalar_comparison_noasm.go b/go/arrow/compute/internal/kernels/scalar_comparison_noasm.go index e877610b372cf..204eaa6d448ea 100644 --- a/go/arrow/compute/internal/kernels/scalar_comparison_noasm.go +++ b/go/arrow/compute/internal/kernels/scalar_comparison_noasm.go @@ -18,7 +18,7 @@ package kernels -import "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" +import "github.com/apache/arrow/go/v13/arrow/compute/exec" func genCompareKernel[T exec.NumericTypes](op CompareOperator) *CompareData { return genGoCompareKernel(getCmpOp[T](op)) diff --git a/go/arrow/compute/internal/kernels/scalar_comparisons.go b/go/arrow/compute/internal/kernels/scalar_comparisons.go index 5e905b514c9e0..8d4ae244397d3 100644 --- a/go/arrow/compute/internal/kernels/scalar_comparisons.go +++ b/go/arrow/compute/internal/kernels/scalar_comparisons.go @@ -25,7 +25,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/internal/debug" diff --git a/go/arrow/compute/internal/kernels/string_casts.go b/go/arrow/compute/internal/kernels/string_casts.go index 344b10364c138..db278fd853d1d 100644 --- a/go/arrow/compute/internal/kernels/string_casts.go +++ b/go/arrow/compute/internal/kernels/string_casts.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/float16" "github.com/apache/arrow/go/v13/internal/bitutils" ) diff --git a/go/arrow/compute/internal/kernels/types.go b/go/arrow/compute/internal/kernels/types.go index 7743b076397c9..b1d0fa0403229 100644 --- a/go/arrow/compute/internal/kernels/types.go +++ b/go/arrow/compute/internal/kernels/types.go @@ -22,7 +22,7 @@ import ( "fmt" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/scalar" ) diff --git a/go/arrow/compute/internal/kernels/vector_hash.go b/go/arrow/compute/internal/kernels/vector_hash.go index abae8e1b0b287..ee592b98b87a5 100644 --- a/go/arrow/compute/internal/kernels/vector_hash.go +++ b/go/arrow/compute/internal/kernels/vector_hash.go @@ -23,7 +23,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/apache/arrow/go/v13/internal/bitutils" diff --git a/go/arrow/compute/internal/kernels/vector_run_end_encode.go b/go/arrow/compute/internal/kernels/vector_run_end_encode.go index 3c5b673f657a8..e5ea93a3ebc47 100644 --- a/go/arrow/compute/internal/kernels/vector_run_end_encode.go +++ b/go/arrow/compute/internal/kernels/vector_run_end_encode.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/float16" diff --git a/go/arrow/compute/internal/kernels/vector_selection.go b/go/arrow/compute/internal/kernels/vector_selection.go index 8edefe2453997..73b54fdeb5420 100644 --- a/go/arrow/compute/internal/kernels/vector_selection.go +++ b/go/arrow/compute/internal/kernels/vector_selection.go @@ -25,7 +25,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/apache/arrow/go/v13/internal/bitutils" diff --git a/go/arrow/compute/registry_test.go b/go/arrow/compute/registry_test.go index e06bd47a7cab3..c447364359287 100644 --- a/go/arrow/compute/registry_test.go +++ b/go/arrow/compute/registry_test.go @@ -25,7 +25,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/stretchr/testify/assert" "golang.org/x/exp/slices" ) diff --git a/go/arrow/compute/scalar_bool.go b/go/arrow/compute/scalar_bool.go index e47830ebc96b7..5678a1fb6943e 100644 --- a/go/arrow/compute/scalar_bool.go +++ b/go/arrow/compute/scalar_bool.go @@ -22,7 +22,7 @@ import ( "fmt" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" ) diff --git a/go/arrow/compute/scalar_compare.go b/go/arrow/compute/scalar_compare.go index dc4d807e3d671..14c0a4d25d0da 100644 --- a/go/arrow/compute/scalar_compare.go +++ b/go/arrow/compute/scalar_compare.go @@ -22,7 +22,7 @@ import ( "context" "github.com/apache/arrow/go/v13/arrow" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" ) diff --git a/go/arrow/compute/scalar_compare_test.go b/go/arrow/compute/scalar_compare_test.go index 460f856e28d47..4643e26ce1873 100644 --- a/go/arrow/compute/scalar_compare_test.go +++ b/go/arrow/compute/scalar_compare_test.go @@ -28,7 +28,7 @@ import ( "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "github.com/apache/arrow/go/v13/arrow/internal/testing/gen" "github.com/apache/arrow/go/v13/arrow/memory" diff --git a/go/arrow/compute/selection.go b/go/arrow/compute/selection.go index 2ce749a053b1f..4593ba0daf4df 100644 --- a/go/arrow/compute/selection.go +++ b/go/arrow/compute/selection.go @@ -24,7 +24,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "golang.org/x/sync/errgroup" ) diff --git a/go/arrow/compute/utils.go b/go/arrow/compute/utils.go index b22b26b2ac7d1..5b3aef1691848 100644 --- a/go/arrow/compute/utils.go +++ b/go/arrow/compute/utils.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/bitutil" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "github.com/apache/arrow/go/v13/arrow/internal/debug" "github.com/apache/arrow/go/v13/arrow/memory" diff --git a/go/arrow/compute/vector_hash_test.go b/go/arrow/compute/vector_hash_test.go index c3aae265c7c51..e83687b12700d 100644 --- a/go/arrow/compute/vector_hash_test.go +++ b/go/arrow/compute/vector_hash_test.go @@ -26,7 +26,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/decimal128" "github.com/apache/arrow/go/v13/arrow/decimal256" "github.com/apache/arrow/go/v13/arrow/memory" diff --git a/go/arrow/compute/vector_run_end_test.go b/go/arrow/compute/vector_run_end_test.go index e00990577ae72..62ea7dba015a2 100644 --- a/go/arrow/compute/vector_run_end_test.go +++ b/go/arrow/compute/vector_run_end_test.go @@ -29,7 +29,7 @@ import ( "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/bitutil" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/internal/testing/gen" "github.com/apache/arrow/go/v13/arrow/memory" "github.com/stretchr/testify/suite" diff --git a/go/arrow/compute/vector_selection_test.go b/go/arrow/compute/vector_selection_test.go index eec403fc90e73..2a97f4c1301bb 100644 --- a/go/arrow/compute/vector_selection_test.go +++ b/go/arrow/compute/vector_selection_test.go @@ -27,7 +27,7 @@ import ( "github.com/apache/arrow/go/v13/arrow" "github.com/apache/arrow/go/v13/arrow/array" "github.com/apache/arrow/go/v13/arrow/compute" - "github.com/apache/arrow/go/v13/arrow/compute/internal/exec" + "github.com/apache/arrow/go/v13/arrow/compute/exec" "github.com/apache/arrow/go/v13/arrow/compute/internal/kernels" "github.com/apache/arrow/go/v13/arrow/internal/testing/gen" "github.com/apache/arrow/go/v13/arrow/memory"