From 107f99d5756d8863a2cc0398754cc1690f20c5d5 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Thu, 28 Mar 2024 16:51:09 +0100 Subject: [PATCH] EXPERIMENT: [C++] Always prefer mimalloc to jemalloc --- cpp/src/arrow/memory_pool.cc | 7 +------ dev/archery/archery/benchmark/runner.py | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/cpp/src/arrow/memory_pool.cc b/cpp/src/arrow/memory_pool.cc index 2f8ce3a6fa8c7..efb5a50181b3b 100644 --- a/cpp/src/arrow/memory_pool.cc +++ b/cpp/src/arrow/memory_pool.cc @@ -85,15 +85,10 @@ struct SupportedBackend { const std::vector& SupportedBackends() { static std::vector backends = { - // ARROW-12316: Apple => mimalloc first, then jemalloc - // non-Apple => jemalloc first, then mimalloc -#if defined(ARROW_JEMALLOC) && !defined(__APPLE__) - {"jemalloc", MemoryPoolBackend::Jemalloc}, -#endif #ifdef ARROW_MIMALLOC {"mimalloc", MemoryPoolBackend::Mimalloc}, #endif -#if defined(ARROW_JEMALLOC) && defined(__APPLE__) +#ifdef ARROW_JEMALLOC {"jemalloc", MemoryPoolBackend::Jemalloc}, #endif {"system", MemoryPoolBackend::System} diff --git a/dev/archery/archery/benchmark/runner.py b/dev/archery/archery/benchmark/runner.py index a91989fb95257..bbd707b954b54 100644 --- a/dev/archery/archery/benchmark/runner.py +++ b/dev/archery/archery/benchmark/runner.py @@ -123,6 +123,8 @@ def default_configuration(**kwargs): with_csv=True, with_dataset=True, with_json=True, + with_mimalloc=True, + with_jemalloc=True, with_parquet=True, with_python=False, with_brotli=True,