From ca1fd27abba578510b8c07c5707919736f5d6db2 Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Mon, 8 Jul 2024 17:08:03 -0700 Subject: [PATCH] fix(c/driver/postgresql): Fix compiler warning on gcc14 (#1990) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As identified by the CRAN checks: ``` Version: 0.12.0 Check: whether package can be installed Result: WARN Found the following significant warnings: c/driver/postgresql/copy/writer.h:218:37: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor] See ‘/data/gannet/ripley/R/packages/tests-devel/adbcpostgresql.Rcheck/00install.out’ for details. * used C++ compiler: ‘g++-14 (GCC) 14.1.0’ ``` https://cran.r-project.org/web/checks/check_results_adbcpostgresql.html --- c/driver/postgresql/copy/writer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/c/driver/postgresql/copy/writer.h b/c/driver/postgresql/copy/writer.h index 528e1f375e..3d74b81681 100644 --- a/c/driver/postgresql/copy/writer.h +++ b/c/driver/postgresql/copy/writer.h @@ -214,7 +214,7 @@ class PostgresCopyIntervalFieldWriter : public PostgresCopyFieldWriter { template class PostgresCopyNumericFieldWriter : public PostgresCopyFieldWriter { public: - PostgresCopyNumericFieldWriter(int32_t precision, int32_t scale) + PostgresCopyNumericFieldWriter(int32_t precision, int32_t scale) : precision_{precision}, scale_{scale} {} ArrowErrorCode Write(ArrowBuffer* buffer, int64_t index, ArrowError* error) override {