[bug] plugin-minimap dispose处理不干净，导致报错

[cyrilluce]

Describe the bug

minimap当前的清理逻辑为

  protected onRemove() {
    this.stopListening()
    this.targetGraph.model = new Model() // <----- 这里
    this.targetGraph.dispose()
  }

原本的意图应该是防止graph.dispose时自动clearCells，导致model被清空。

但现在这个写法会导致 graph.renderer.sheduler dispose 时，未能正确清理UI渲染相关的监听器，从而导致报错

此问题仅在minimap单独销毁时出现（例如动态开关/切换minimap）

Your Example Website or App

无

Steps to Reproduce the Bug or Issue

无

Expected behavior

不应该有报错

Screenshots or Videos

可以看到经过反复注册销毁，graph.model上绑定了很多未清理的监听器

Platform

• OS: [e.g. macOS, Windows, Linux]
• Browser: [e.g. Chrome, Safari, Firefox]
• Version: [e.g. 2.11.1]

Additional context

No response

[cyrilluce]

一种临时修复方法

import { Graph } from '@antv/x6';
import { MiniMap } from '@antv/x6-plugin-minimap';

export default class MyMinimapPlugin extends MiniMap {
    onRemove() {
        this.stopListening();
        // TODO 过于hack，如果graph的代码变了，这里也会有问题
        this.targetGraph.clearCells = noop;
        this.targetGraph.dispose();
    }
}

function noop(this: Graph) {
    return this;
}

[x6-bot]

This thread has been automatically locked because it has not had recent activity.

Please open a new issue for related bugs and link to relevant comments in this thread.