Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger dblclick event only one time #3577

Merged
merged 1 commit into from
May 9, 2023
Merged

fix: trigger dblclick event only one time #3577

merged 1 commit into from
May 9, 2023

Conversation

NewByVector
Copy link
Contributor

Description

Close #3575 #3559

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added pkg:x6 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. PR(fix) :bug: Bug Fix labels May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3577 (21b664c) into master (35aa68b) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3577   +/-   ##
=======================================
  Coverage   10.36%   10.36%           
=======================================
  Files         180      180           
  Lines       10497    10497           
  Branches     2552     2552           
=======================================
  Hits         1088     1088           
  Misses       9320     9320           
  Partials       89       89           
Flag Coverage Δ
x6 10.36% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/registry/tool/editor.ts 5.75% <0.00%> (ø)

@NewByVector NewByVector merged commit aa65bfa into master May 9, 2023
@NewByVector NewByVector deleted the fix/editor branch May 9, 2023 08:36
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels May 9, 2023
@hylerrix
Copy link
Contributor

hylerrix commented Jul 12, 2023

@NewByVector 这个改动我在最新的 v1.34.14 版本也遇到了,可以将 pr 也更新到 v1.x 版本中吗?

我看 PR 里的相关改动,在 v1 里代码非常不一样,所以让我来的话我也不知道从何下手。

CleanShot 2023-07-12 at 19 03 33

@NewByVector
Copy link
Contributor Author

@hylerrix 可以把 cell-editor 的源码拉出来,自定义自己的工具。使用方式和 2.x 对齐。

@hylerrix
Copy link
Contributor

@hylerrix 可以把 cell-editor 的源码拉出来,自定义自己的工具。使用方式和 2.x 对齐。

感谢提醒,那也就是 x6 官方不准备在 v1.x 中修补了?

@NewByVector
Copy link
Contributor Author

@hylerrix 使用方式不太一样,如果修改是 break change,所以不准不准在 1.x 中修改了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR(fix) :bug: Bug Fix PR: merged PR has merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edge的edge-editor和vertices工具,有冲突
2 participants