Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter diff output #280

Closed
wants to merge 4 commits into from
Closed

Filter diff output #280

wants to merge 4 commits into from

Conversation

olemyhre
Copy link
Contributor

@olemyhre olemyhre commented Oct 1, 2022

SUMMARY

Filter diff output so the module wont report empty diffs when there are no actual changes after a config replace.

Fixes #269

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iosxr_config

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 01s
✔️ build-ansible-collection SUCCESS in 3m 57s
✔️ ansible-tox-linters SUCCESS in 5m 08s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 3m 56s
✔️ ansible-tox-linters SUCCESS in 5m 06s

@ashwini-mhatre
Copy link
Contributor

@olemyhre could you please add some integration tests?

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 3m 55s
✔️ ansible-tox-linters SUCCESS in 5m 13s

@olemyhre olemyhre closed this by deleting the head repository Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to achieve idempotency with iosxr_config and replace: config - option
3 participants