Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vamp-IR lib doesn't compile #84

Closed
lopeetall opened this issue Apr 25, 2023 · 3 comments
Closed

Vamp-IR lib doesn't compile #84

lopeetall opened this issue Apr 25, 2023 · 3 comments

Comments

@lopeetall
Copy link
Contributor

anoma/taiga#157 (comment)
@lopeetall
Copy link
Contributor Author

@XuyangSong can you detail the compilation issue with the lib?

@lopeetall
Copy link
Contributor Author

I merged in some changes that may have fixed this, would you confirm @XuyangSong?

@XuyangSong
Copy link

I merged in some changes that may have fixed this, would you confirm @XuyangSong?

Thanks, it works!
Do you plan to update the dependencies version of Halo2(halo2_proofs, halo2_gadgets, group, ff)? There are some updates about the Field traits in the new version, which makes the versions incompatible. In Taiga, we updated to the latest versions recently. When I want to set the Halo2Module<F: PrimeField> field, the compiler complains of some unsatisfied traits.
Btw, it would be very helpful if you could make the mod util public.

@lopeetall lopeetall mentioned this issue May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lopeetall @XuyangSong