Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves on try_recv in e2e tests #3897

Open
grarco opened this issue Oct 7, 2024 · 1 comment
Open

Improves on try_recv in e2e tests #3897

grarco opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels

Comments

@grarco
Copy link
Contributor

grarco commented Oct 7, 2024

About the mpsc channel read loop in e2e tests

match abort_recv.try_recv() {

          unrelated to this PR, but this `try_recv` might be contributing substantially to the resource usage of e2e tests :P

Originally posted by @sug0 in #3894 (comment)

Seems like the solution is to call recv_timeout instead with a sane timeout

@grarco
Copy link
Contributor Author

grarco commented Oct 9, 2024

I've actually tried to implement this and the tests started to fail. Specifically they fail in exp_regex on a Hermes NamadaCmd because of a timeout on the output stream when creating the IBC channel (create_channel_ibc_with_hermes). This does not depend on the specific timeout we set neither in recv_timeout nor in the Session. It could be due to the Session instances of Namada and Gaia controlling the streams of their processes: being blocked would prevent them from replying to the Hermes requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant