Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test masp edge cases #3836

Open
3 of 14 tasks
grarco opened this issue Sep 20, 2024 · 0 comments
Open
3 of 14 tasks

Test masp edge cases #3836

grarco opened this issue Sep 20, 2024 · 0 comments

Comments

@grarco
Copy link
Contributor

grarco commented Sep 20, 2024

We should try to test some masp edge cases:

  • Test a block (or even batch) with one shielded action and one MASP tx in both orders and check that the shielded sync command always reconstruct the correct state
  • Test a batch containing two masp txs, one successful and one failing (in both orders) and check that the protocol and the shielded sync command work as expected. Also test with an atomic batch (Masp tests #3840)

Also test some malicious masp transactions:

  • A non-MASP transaction that carries a MASP section (check both the case as-is and the one where the tx manually triggers the MASP VP) (Masp tests #3840)
  • A valid masp tx that carries more than one masp section (check that both the protocol and the shielded sync command ignore the unused masp sections) (Masp tests #3840)
  • A valid shielded action tx that also carries a masp section (same checks as above)
  • A MASP tx with an invalid conversion
  • A MASP tx that does not reveal a necessary nullifier
  • A MASP tx that does not append a required output description to the commitment tree
  • A MASP tx that arbitrarily rewrites the commitment tree
  • A MASP tx with a mismatch between the sapling value balance and the actual changes to the transparent balance
  • A malleability attack on an outgoing shielded action where the actual IBC target gets modified
  • An outgoing shielded action without the required masp section
  • An outgoing shielded action with a wrong masp section
  • An incoming shielded action with no masp transaction in its memo
@grarco grarco self-assigned this Sep 20, 2024
@grarco grarco mentioned this issue Sep 23, 2024
3 tasks
@mergify mergify bot mentioned this issue Oct 14, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant