Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zork Zero: White border under the status line #93

Open
dfabulich opened this issue Aug 13, 2024 · 1 comment
Open

Zork Zero: White border under the status line #93

dfabulich opened this issue Aug 13, 2024 · 1 comment

Comments

@dfabulich
Copy link

White border under the status line (something similar occurs on the title screen when you ne.s.w.e.w.dive under table.z.z.z)

https://intfiction.org/t/spatterlight-release-1-2-5-is-out/70302/10?u=dfabulich

White line under banner: Offhand I think this is because the banner window is drawn slightly larger than the first border you see (the other borders, e.g. the green one, are a bit taller than this image). To simplify things I keep the top window the same size for all borders; but it looks like Spatterlight defaults the background of graphics windows to white. It’s sort of a Glk implementation issue, then, but if that’s not really changeable, I may be able to adapt the top graphics window to the banner size. @angstsmurf will have Spatterlight insight here.

image

image

@cspiegel
Copy link
Contributor

My initial suspicion was right. The castle banner is smaller in size (320x34) than the outside/underground banners (320x39). Bocfel just builds a 320x40 window (I have no clue why I did 40; it probably should be 39, but that's not the point here) and draws the images there. That means there's a bit of space under the castle banner, and that differs from the color set by the game with the Amiga interpreter.

The obvious fix is to resize the window to each banner, which is easy enough, but then the compass rose gets cut off for the castle banner. With a 320x40 window:

image

With a 320x34 window:

image

(ignore the palette problems: I used a non-BPal Blorb when testing this)

The 320x34 banner "expects" the compass rose to extend below it.... for some reason. This differs in the EGA and CGA versions (the Blorb file comes from the MCGA versions). The EGA version isn't cut off, but the castle banner is slightly different-sized: 640x37 vs 640x39 for the other two. The CGA version isn't cut off either, and is the same size (640x39) as the outside banner, but the underground banner is 640x38.

This weird cutoff banner is visible in the DOS version of Zork Zero, so it's not a problem with the Blorb conversion or something like that. I'm not sure what the best thing to do here is. Fixing the window size cuts off the compass rose as shown, but having the window be the "right" size, to keep the compass rose, has the color issue.

Suggestions are welcome. I'm inclined to keep it as-is (perhaps with a change to 320x39 for the window size), and just recommend against using the Amiga interpreter for Zork Zero. But if there's a better approach I'm all ears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants