Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test setup improvement and more tests #7

Open
tahv0 opened this issue Jan 14, 2019 · 1 comment
Open

Test setup improvement and more tests #7

tahv0 opened this issue Jan 14, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tahv0
Copy link

tahv0 commented Jan 14, 2019

This module has very little tests or no tests at all for some scenarios. There is need for movement from "production tested" to improved test system.
I think that this module needs following tests

Module promises:

  • Module promises reconnection and Error handling. no tests
  • Tests for continuous health checks. no tests
  • Proper error handling very little tests

Other tests could be:

  • "Stress testing". Trigger hundreds or thousands events in Postgres db and handle events
  • Test for module imports (commonjs, es6 import)
  • listen many channels with single subscriber
@andywer andywer added the enhancement New feature or request label Mar 25, 2019
@andywer
Copy link
Owner

andywer commented May 15, 2019

The situation has improved a bit:
There is now an integration test that makes sure the library re-connects properly, that the channels are re-subscribed to and that notifications still work afterwards.

Test coverage should still be improved, though (see above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants