Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths broken when adding multiple subdirs of / #359

Open
tlotze opened this issue Nov 14, 2022 · 4 comments
Open

Paths broken when adding multiple subdirs of / #359

tlotze opened this issue Nov 14, 2022 · 4 comments
Labels
bug A bug of moderate or unknown severity fixed-on-master

Comments

@tlotze
Copy link

tlotze commented Nov 14, 2022

When I put multiple directories with the same call, they will be stored as subdirectories of the common parent. However, when I do this with different subdirectories of the filesystem root, such as # bupstash put /etc /home, the paths will be broken:

# bupstash list-contents
drwxr-xr-x -         2022/11/07 11:05:36 .
drwxr-xr-x -         2022/11/14 19:25:52 tc
drwxr-xr-x -         2022/02/08 09:41:19 ome
...

and bupstash get --pick will also refer to those mangled paths.

@andrewchambers andrewchambers added the bug A bug of moderate or unknown severity label Nov 15, 2022
@andrewchambers
Copy link
Owner

Thanks for the report - it seems like this slipped through because the test suite can't test the root directory so easily.

@andrewchambers
Copy link
Owner

This has been fixed in master and will be in the next bug fix release.

@klemensn
Copy link
Contributor

klemensn commented Jan 1, 2023

This has been fixed in master and will be in the next bug fix release.

This happens when testing #363 on top of 0.12.0, which is what I did through the official OpenBSD port/package, where tests failed unexpectedly.

This PR lacked a reference to the actual fix, so here it is: a73fd83.

@andrewchambers
Copy link
Owner

I will try to do a release in the next week or so we can get this fix out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug of moderate or unknown severity fixed-on-master
Projects
None yet
Development

No branches or pull requests

3 participants