New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary min() call #157

Open

KevinJW opened this issue Oct 16, 2024 · 0 comments

KevinJW commented Oct 16, 2024

The line here

aces-core/lib/Lib.Academy.OutputTransform.ctl

Line 873 in 89a10fd

float gain = (limitJmax - thr) / max(0.0001, (limitJmax - min(limitJmax, J)));

does not need the min() call as the max() is more limiting.

Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment