Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for phpunit using PHP 8.1 and 8.2 to CI #1015

Closed
kevinfodness opened this issue Sep 25, 2023 · 2 comments · Fixed by #1019
Closed

Add Support for phpunit using PHP 8.1 and 8.2 to CI #1015

kevinfodness opened this issue Sep 25, 2023 · 2 comments · Fixed by #1019
Assignees
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request
Milestone

Comments

@kevinfodness
Copy link
Member

kevinfodness commented Sep 25, 2023

Description

I would like to see unit tests that test Publish to Apple News using PHP 8.1 and 8.2.

Use Case

Run phpunit using PHP 8.1 and 8.2.

Acceptance Criteria

  • Ensure that phpunit is configured to run on PHP 8.1 and PHP 8.2 in GitHub Actions.
  • Ensure all phpunit tests pass in PHP 8.1 and PHP 8.2
  • Add the new PHP 8.1 and PHP 8.2 phpunit tests to branch protections (requires admin, ask a lead dev to do this).

Technical Details

@kevinfodness kevinfodness added the enhancement New feature or request label Sep 25, 2023
@kevinfodness kevinfodness added this to the v2.4.1 milestone Sep 25, 2023
@kevinfodness kevinfodness changed the title Add Support for phpunit using PHP 8.2 to CI Add Support for phpunit using PHP 8.1 and 8.2 to CI Sep 25, 2023
@kevinfodness kevinfodness added the ci/cd PR checks, deploys, automation label Oct 20, 2023
@SiteBastion
Copy link

SiteBastion commented Oct 28, 2023

Since PHP 8 is now EOF, can this get a bump/ETA? Some hosts are forcing updates to 8.1 with 8.2 being preferred and also set to default for all new installs (WPEngine for instance)

Also, will test on 8.1/8.2 in coming week.

@attackant attackant self-assigned this Oct 30, 2023
@attackant attackant linked a pull request Oct 30, 2023 that will close this issue
@kevinfodness
Copy link
Member Author

@SiteBastion We are working on this currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants