Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Algorand Code or SDK repositories with Significant PR [100 - 2000 ALGO] #42

Closed
1 task
michielmulders opened this issue Jun 11, 2021 · 33 comments
Closed
1 task

Improve Algorand Code or SDK repositories with Significant PR [100 - 2000 ALGO] #42

michielmulders opened this issue Jun 11, 2021 · 33 comments
Labels
Advanced Experience Level: Advanced Beginner Experience Level: Beginner Development Tasks that involve development works Intermediate Experience Level: Intermediate

Comments

@michielmulders
Copy link
Contributor

michielmulders commented Jun 11, 2021 •
edited by Mine77
Loading

Overview

  • Short Description: Improve Algorand source code by providing features or bug fixes
  • Bounty: 100 - 2000 ALGO tokens (US residents will receive USDCa and have to opt-in to receive the asset in their wallet)
  • Estimated Time Commitment: variable
  • Category: Developer (AlgoDev)
  • Experience Level: Beginner / Intermediate / Advanced

Description

What is this task?

This task involves providing significant fixes to existing bugs or providing additional features that get approved into one of the Algorand repositories. This could be fixing a known bug, or supply a requested feature that helps the Algorand core project or SDK repositories.

What are the requirements for the bounty taker?

The developer should have knowledge of the Algorand source or SDKs.

What are the deliverables?

1. Pull Request

Description
The developer should provide a completed pull request that has been accepted into one of the Algorand repositories. This PR should represent a significant bug fix or enhancement feature.

Judging Criteria and Metrics

  • Quality of Code
  • Approval of the PR

Submission Procedure

  • Submit your PR link on Gitcoin.

Other Requirements

  • All project codes should be published on GitHub, with MIT license or Apache V2 license.
  • All contributions/PRs to public (Algorand) repositories should be open source and should follow the contributions rules of the relevant repository.
  • All non-codes documents should be using Markdown format.
  • In the project description or repository readme, there should be a proper security notice. E.g., it should tell the visitor the project is not audited and should not be used in a production environment.
  • You are not eligible to receive additional rewards through other Algorand programs like the developer ambassadors program.
@michielmulders michielmulders added Development Tasks that involve development works Beginner Experience Level: Beginner Intermediate Experience Level: Intermediate Advanced Experience Level: Advanced labels Jun 11, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 ALGO (103.0 USD @ $1.03/ALGO) attached to it as part of the algorandfoundation fund.

@michielmulders
Copy link
Contributor Author

@barnjamin Can you re-apply for the bounty and we will review it. We had some issues on our side and had to republish the bounty. Sorry for the inconvenience!

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 ALGO (104.0 USD @ $1.04/ALGO) has been submitted by:

@gitcoinbot
Copy link

gitcoinbot commented Jun 16, 2021 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 ALGO (89.10 USD @ $0.88/ALGO) has been submitted by:

  1. @barnjamin
  2. @jordpw
  3. @figurestudios
  4. @irishcortel
  5. @peejae
  6. @catalanfree
  7. @eugine2021
  8. @arquio2020
  9. @phinoytv
  10. @jkschin
  11. @urajbhandari
  12. @niraj-kamdar
  13. @amityadav0

@michielmulders please take a look at the submitted work:

@gitcoinbot
Copy link

gitcoinbot commented Jun 19, 2021 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 4 days, 16 hours ago.
Please review their action plans below:

1) figurestudios has started work.

updated installment steps
algorand/py-algorand-sdk#203
algorand/indexer#548
bonus grammar/spelling errors mostly in README’s
#61
#62
#63
algorand/go-algorand#2309
algorand/sandbox#51
algorand/generator#10
mix between the two
algorand/js-algorand-sdk#381
2) niraj-kamdar has started work.

feat: runtime type checker created for Python SDK SuggestedParams class.
3) thedreamer2021 has started work.

I want to try to participate in the hackathon, I try my very best
4) jkschin has started work.

Fix issue 187 in py-algorand-sdk.
5) urajbhandari has started work.

Create PR for algorand/java-algorand-sdk#95
6) amityadav0 has started work.

algorand/js-algorand-sdk#391

Learn more on the Gitcoin Issue Details page.

@michielmulders
Copy link
Contributor Author

michielmulders commented Jun 21, 2021 •
edited
Loading

@hhio618 Can you provide more info on how you want to improve the Go SDK?

@michielmulders
Copy link
Contributor Author

@jordpw Repeating here: Sorry, that PR is too small to be eligble

@michielmulders
Copy link
Contributor Author

@Niraj-Kamdar What's the benefit of the runtime type checker created for Python SDK SuggestedParams class?

@Niraj-Kamdar
Copy link

@Niraj-Kamdar What's the benefit of the runtime type checker created for Python SDK SuggestedParams class?

Here's the related issue: algorand/py-algorand-sdk#179
Since python is dynamic typing language it don't assert on type automatically and that's why it won't be able to detect the type mismatch until the transaction execute.

@hhio618
Copy link

hhio618 commented Jun 21, 2021

@hhio618 Can you provide more info on how you want to improve the Go SDK?

I can work on any open issue like this one: algorand/go-algorand-sdk#190, but I'm open to any other suggestions!

@michielmulders
Copy link
Contributor Author

@Niraj-Kamdar What's the benefit of the runtime type checker created for Python SDK SuggestedParams class?

Here's the related issue: algorand/py-algorand-sdk#179
Since python is dynamic typing language it don't assert on type automatically and that's why it won't be able to detect the type mismatch until the transaction execute.

Hi @Niraj-Kamdar , yes, that would work and would be a great addition. As you were first, feel free to tackle this issue. You can communicate with the issue creators in the thread on issue 179 in the py-algorand-sdk.

@jkschin I'm sorry, Niraj was first to claim this issue. If he can't complete the task, I'm happy for you to tackle it. Thanks for applying!

@jkschin
Copy link

jkschin commented Jun 22, 2021

@michielmulders no worries. I'm actually just looking through all the issues in py-algorand-sdk and tackling them first before thinking about the bounty. Can you point me to any other open issues?

@michielmulders
Copy link
Contributor Author

michielmulders commented Jun 22, 2021 •
edited
Loading

You can take a look here but there aren't many issues left. @jackyzhang1981 Also, I've asked what the FDE label means.

@michielmulders
Copy link
Contributor Author

@hhio618 Can you provide more info on how you want to improve the Go SDK?

I can work on any open issue like this one: algorand/go-algorand-sdk#190, but I'm open to any other suggestions!

Looks like a great issue @hhio618 - Can you reply to the thread and tag the person who created the issue to check if it's still valid as its created in 2020. Thanks!

@jkschin
Copy link

jkschin commented Jun 22, 2021

@michielmulders did you put the correct link? Your link brings me to a specific issue.

@michielmulders
Copy link
Contributor Author

@jackyzhang1981 sorry meant to send you to the issue overview: https://github.com/algorand/py-algorand-sdk

@jkschin
Copy link

jkschin commented Jun 23, 2021

@michielmulders it's my first time participating in a Gitcoin Hackathon so I might not be doing the admin side of things correctly. I just got a PR merged and fixed algorand/py-algorand-sdk#193. I started and submitted the work on Gitcoin, but I'd also like to work on algorand/py-algorand-sdk#192. Does this Hackathon allow us to submit two separate PRs?

@michielmulders
Copy link
Contributor Author

@jkschin Can you check if you can submit a second PR? I don't think so but it's a cooperative contest, so might be possible. We also don't know, let me know once tested.

@michielmulders
Copy link
Contributor Author

michielmulders commented Jun 24, 2021 •
edited
Loading

@jkschin Feel free to work on algorand/py-algorand-sdk#192
Can you DM me on Discord with your wallet address and residency? Discord name --> Michiel | Algorand Foundation#6116
If your work is done, you can always submit via DM if it's not possible to submit a second time via Gitcoin but try it out first please.

@jkschin
Copy link

jkschin commented Jun 24, 2021

@michielmulders how do I join the channel on discord? The Gitcoin Discord link above doesn't seem to work and I can't seem to find a way to join.

@jkschin
Copy link

jkschin commented Jun 24, 2021

@michielmulders I'm also working on algorand/py-algorand-sdk#187 and have submitted a PR already. Will DM you on Discord when that merges.

@Niraj-Kamdar
Copy link

@michielmulders I have some issues during integration test because type sanity checks are failing due to invalid input type.
algorand/py-algorand-sdk#204

@michielmulders
Copy link
Contributor Author

@michielmulders I have some issues during integration test because type sanity checks are failing due to invalid input type.
algorand/py-algorand-sdk#204

I've tagged Jason who can help you there. I'm not maintaining the repo so can't help with the tests.

@jkschin
Copy link

jkschin commented Jul 6, 2021

@michielmulders got a notification from Gitcoin saying that this funded issue is expiring in 2 days. I'd like to wrap up these two PRs: algorand/py-algorand-sdk#207 and algorand/py-algorand-sdk#209. Happy to finish them after it expires as well.

@Niraj-Kamdar
Copy link

Niraj-Kamdar commented Jul 6, 2021 •
edited
Loading

I've tagged Jason who can help you there. I'm not maintaining the repo so can't help with the tests.

It's been 12 days, still waiting for the code review.

@Mine77
Copy link
Contributor

Mine77 commented Jul 7, 2021 via email

@Niraj-Kamdar
Copy link

@Mine77 Should I go ahead and submit the work since bounty is going to expire in couple of days? happy to do few changes afterwards.

@Mine77
Copy link
Contributor

Mine77 commented Jul 8, 2021

@Niraj-Kamdar Yes you can still go ahead and make a submission.

@jkschin
Copy link

jkschin commented Jul 14, 2021

@michielmulders, algorand/py-algorand-sdk#207 has merged. I'm still working on algorand/py-algorand-sdk#209.

@michielmulders
Copy link
Contributor Author

@jkschin thank you, tracking this one in the bounty sheet. Ping me here once the other one has been merged.

@DamianB-BitFlipper
Copy link

I have two PRs pending. Gitcoin only allows for one per submission, so Michiel told me to note them down here.

algorand/py-algorand-sdk#214
algorand/go-algorand-sdk#232

They both have to do with adding a WaitForConfirmation function the Python and Golang SDK. I have found this function useful when programming, and thought it makes sense to incorporate it directly in the SDK rather than copy code into my projects. This function blocks and waits for a pending transaction to be confirmed by the network.

@Dodydo733
Copy link

😎😙👍

@michielmulders
Copy link
Contributor Author

For further PR improvements, we've created a new bounty issue: #80

Gitcoin link: https://gitcoin.co/issue/algorandfoundation/grow-algorand/80/100026172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Advanced Experience Level: Advanced Beginner Experience Level: Beginner Development Tasks that involve development works Intermediate Experience Level: Intermediate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@hhio618 @DamianB-BitFlipper @jkschin @Mine77 @michielmulders @gitcoinbot @Niraj-Kamdar @Dodydo733