Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between algod and indexer API result #597

Closed
rotemh opened this issue Jul 27, 2021 · 1 comment
Closed

Inconsistency between algod and indexer API result #597

rotemh opened this issue Jul 27, 2021 · 1 comment
Labels
new-bug Bug report that needs triage Team Lamprey

Comments

@rotemh
Copy link

rotemh commented Jul 27, 2021

Subject of the issue

it seems like algod removes empty values and indxer doesn't.

Steps to reproduce

https://indexer-mainnet/v2/assets/278022289

{
"asset":{
"created-at-round": 15042440,
"deleted": false,
"index": 278022289,
"params":{
"clawback": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ",
"creator": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"decimals": 0,
"default-frozen": false,
"freeze": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY5HFKQ",
"manager": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"metadata-hash": "RUFEREU0NTVBOUNBQjBGRUU2NzBEREI2MDNBQjUyNDg=",
"name": "Mask #7",
"reserve": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"total": 17,
"unit-name": "MTMASK7",
"url": "https://bit.ly/3xLUSV0"
}
},
"current-round": 15252300
}

VS

https://node-mainnet/v2/assets/278022289

{
"index": 278022289,
"params":{
"creator": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"decimals": 0,
"default-frozen": false,
"manager": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"metadata-hash": "RUFEREU0NTVBOUNBQjBGRUU2NzBEREI2MDNBQjUyNDg=",
"name": "Mask #7",
"reserve": "JADXUXWQ5CWU2G2TTBMY7NCWGDHO3SLY7IPYVC37GTFARAZ2N5LBLWAP5A",
"total": 17,
"unit-name": "MTMASK7",
"url": "https://bit.ly/3xLUSV0"
}
}

Expected behaviour

I'd expect indexer to return empty values just when they have a meaning.

Actual behaviour

Indexer returns the 0 byte address here when the user probably didn't set it at all.

Acceptance criteria:

The following params (clawback, freeze, reserve) should not be returned if empty.
These params are currently optional.

@chaihoang
Copy link

Duplicate of #939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-bug Bug report that needs triage Team Lamprey
Projects
None yet
Development

No branches or pull requests

3 participants