Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: create a cfg struct to inject dep #64

Closed
drgorillamd opened this issue Apr 17, 2024 · 2 comments
Closed

Refactor: create a cfg struct to inject dep #64

drgorillamd opened this issue Apr 17, 2024 · 2 comments
Labels
Good First Issue Good for newcomers Refactor A change that doesn't meaningfully change the behavior of the program

Comments

@drgorillamd
Copy link
Contributor

Right now, arg parsed with clap are passed as individual values to the relevant fn, as there are only 4 of them for scaffold (w, f, s and S) and 2 for check.

As more option are introduced, an ever-growing list of function parameters isn't sustainable and should rather be part of a struct (leaving the cli arg versus Bulloak.toml discussion for #38 ).

let scaffolder = Scaffolder::new(&self.solidity_version, &self.with_vm_skip);

would become

let scaffolder = Scaffolder::new(&self.cfg);
@alexfertel alexfertel added Good First Issue Good for newcomers Refactor A change that doesn't meaningfully change the behavior of the program labels Apr 17, 2024
@alexfertel
Copy link
Owner

Resolved by #67 (forgot to mention the issue in the PR description)

@alexfertel
Copy link
Owner

I'll tackle #38 next probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Refactor A change that doesn't meaningfully change the behavior of the program
Projects
None yet
Development

No branches or pull requests

2 participants