Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker container to tests (and run them from within!) #58

Open
phinate opened this issue Jun 28, 2023 · 2 comments
Open

Add docker container to tests (and run them from within!) #58

phinate opened this issue Jun 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@phinate
Copy link
Collaborator

phinate commented Jun 28, 2023

Currently, we copy a lot of CI from poke-env to setup the showdown side of things. I think it would be much better to incorporate the necessary aspects of this into our Dockerfile written by @boykovdn, and then run the tests in that docker container, building it on the fly for every test run.

This way, we keep our Docker image shiny and updated, while also making a possibly re-usable pokemon showdown github action! See e.g. https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

@phinate
Copy link
Collaborator Author

phinate commented Jun 28, 2023

@hsahovic, let me know if that's something you'd be interested in! And thanks for the nicely written CI, made it very easy for us to set up testing :)

@phinate phinate added the enhancement New feature or request label Jun 28, 2023
@hsahovic
Copy link

Thanks! If you set something like this up, let me know - I might want to implement something similar in poke-env :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants