Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker continuous integration #75

Closed
2 of 3 tasks
griff-rees opened this issue Oct 26, 2023 · 2 comments · Fixed by #83
Closed
2 of 3 tasks

docker continuous integration #75

griff-rees opened this issue Oct 26, 2023 · 2 comments · Fixed by #83
Assignees
Labels
enhancement New feature or request

Comments

@griff-rees
Copy link
Collaborator

griff-rees commented Oct 26, 2023

Given much of the data requires mounting locally, either on an azure virtual machine or a local machine, I would find it quite helpful to have a docker configuration for replicating the server configuration locally for testing. This could then be incorporated in GitHub actions for easing future collaboration.

The docker-config branch (not quite updated, have had a few forks since then) is an example of this ilk. Again: this is not meant as the only way the code can be run, but as an easier way to automate testing in a similar configuration across users/platforms etc. covering both python and R. This would also lower regular costs in server time.

  • See how everyone feels about this as a merge request. Happy to take down and just manage locally if necessary. Main issue with that is it could make automating GitHub Actions a lot easier, hence relation to Continuous integration #76)
  • If a merge is ok, the current request is Docker config #83
  • Documentation to explain/ease testing locally
@griff-rees griff-rees self-assigned this Oct 26, 2023
@griff-rees griff-rees added the enhancement New feature or request label Oct 26, 2023
@gmingas gmingas mentioned this issue Nov 2, 2023
4 tasks
@dingaaling dingaaling added this to the 10 Nov - 23 Nov milestone Nov 9, 2023
@dingaaling
Copy link
Collaborator

  • keep as branch or PR to merge?
  • link this ticket with the PR
  • expand out documentation for easier demo

@griff-rees griff-rees linked a pull request Nov 9, 2023 that will close this issue
4 tasks
@griff-rees
Copy link
Collaborator Author

Thanks @dingaaling! The relevant pull request is #83. I've fleshed out your bullet points in the ticket directly, hope that's ok.

griff-rees pushed a commit that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants