Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 cleanup #334

Merged
merged 3 commits into from
Sep 27, 2024
Merged

V2 cleanup #334

merged 3 commits into from
Sep 27, 2024

Conversation

timlrx
Copy link
Collaborator

@timlrx timlrx commented Sep 27, 2024

Description

Remove obsolete folders:

  • ai-verify-portal, ai-verify-shared-library, test-engine-api, test-engine-app

Remove obsolete deployment scripts:

  • folders: examples, setup-aiverify, scripts
  • scripts: pyproject.toml, install_aiv_api_lib_run_examples.sh, dev-requirements.txt, run_unit_test.sh

Rename test-engine-core to aiverify-test-engine in the main module as well as updated stock plugins and all associated tests.

Note: There are still some references to test_engine_core in the github workflow yaml files. I think we can fix those later on to restore all the CI testing functionality.

How to Test

Run pytest in aiverify-test-engine and for stock plugins run the following bash script in a clean venv:

for dir in aiverify*/algorithms/*; do
    if [ -d "$dir" ]; then
        if [ -f "$dir/pyproject.toml" ]; then
            echo "Running pip install in $dir"
            (cd "$dir" && pip install .[dev])
            echo "Running pytest in $dir" | tee -a all_test.log
            (cd "$dir" && pytest) | tee -a all_test.log
        fi
    fi
done

Here's the copy of my test report:
all_test.log

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

Copy link
Contributor

@imda-peckyoke imda-peckyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@imda-peckyoke imda-peckyoke merged commit c62dba6 into v2.x Sep 27, 2024
0 of 3 checks passed
@imda-peckyoke imda-peckyoke deleted the v2-cleanup branch September 27, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants