Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enabling https://pre-commit.ci #274

Open
1 task done
anneschuth opened this issue Mar 21, 2024 · 3 comments
Open
1 task done

[FEATURE] Enabling https://pre-commit.ci #274

anneschuth opened this issue Mar 21, 2024 · 3 comments
Labels
feature Should build this needs-triage Issues need triages by maintainer

Comments

@anneschuth
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Would you consider enabling https://pre-commit.ci for the repo?

Is your feature request related to a problem/limitation?

We are now regularly hitting unrelated changes when we are (automatically) running pre-commit locally.

Describe the solution you'd like

I'd like to see pre-commit to be checked on CI.

Alternatives

No response

Additional Context

No response

Related Issues/PRs

No response

@anneschuth anneschuth added feature Should build this needs-triage Issues need triages by maintainer labels Mar 21, 2024
@anneschuth
Copy link
Contributor Author

Hi!

Would you consider enabling this so that the pre-commit is enforced?

Next, I'd like to make a PR that applies pre-commit run --all-files.

@anneschuth
Copy link
Contributor Author

@imda-benedictlee you may have an opinion on this?

@imda-benedictlee
Copy link
Contributor

imda-benedictlee commented Apr 9, 2024

Hi @anneschuth, thanks for the suggestion. I am currently looking at it. Will provide my thoughts on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Should build this needs-triage Issues need triages by maintainer
Projects
None yet
Development

No branches or pull requests

2 participants