Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for async deserializer #1833

Open
akolenko-tcs opened this issue Oct 3, 2024 · 4 comments
Open

Feature: Add support for async deserializer #1833

akolenko-tcs opened this issue Oct 3, 2024 · 4 comments
Labels
Confluent Issues related to `faststream.confluent` module enhancement New feature or request

Comments

@akolenko-tcs
Copy link

Hello again! I've decided to reopen the issue #1820. I didn't ask for adding avro code to your library, I just wanted to suggest adding support for async deserializers.

In the example of faststream deserialization (https://faststream.airt.ai/latest/getting-started/serialization/examples/#avro) you have msg_dict = fastavro.schemaless_reader(bytes_reader, schema). However, in the example I've provided in that issue was writer_schema = await self._schema_registry.get_by_id(schema_id). So async deserialization would be really useful for using your library.

Hope that you understood what I've meant. If you have any questions, feel free to ask them.

@akolenko-tcs akolenko-tcs added the enhancement New feature or request label Oct 3, 2024
@Lancetnik
Copy link
Member

"Reopen Issue" is not the same with "create a new one"

Also, I still can't get your idea. You refer to not-FastStream code (avro serialization), so I don't think, that we can/should improve it

Can you suggest any API to explain me how it should works?

@Lancetnik
Copy link
Member

Lancetnik commented Oct 3, 2024

Probably, your Issue related to #1774 and #1297

@Lancetnik Lancetnik added the Confluent Issues related to `faststream.confluent` module label Oct 3, 2024
@Lancetnik
Copy link
Member

@kumaranvpl can you help me here, please?

@kumaranvpl
Copy link
Contributor

@kumaranvpl can you help me here, please?

I have no idea what he is talking about. Avro serialization is just an example and @akolenko-tcs is free to use whatever serialization he wants.

It could be better if he just provides a faststream code example rather than providing a vague AsyncDeserializer class which adds to more confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confluent Issues related to `faststream.confluent` module enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants