Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test for the function with testthat #38

Open
BatoolMM opened this issue Jan 2, 2024 · 2 comments · May be fixed by #124
Open

Create a test for the function with testthat #38

BatoolMM opened this issue Jan 2, 2024 · 2 comments · May be fixed by #124
Assignees
Labels
enhancement Feature improvement or addition

Comments

@BatoolMM
Copy link
Member

BatoolMM commented Jan 2, 2024

This is not a priority and doesn’t need to be completed before we make the package public.

It's to add a unit test to the function so that when optimised, we can test it.

@RayStick feel free to remove the issue if you think it's not needed at all or has been mentioned in another issue that I missed.

@BatoolMM BatoolMM added the enhancement Feature improvement or addition label Jan 2, 2024
@BatoolMM BatoolMM self-assigned this Jan 2, 2024
@RayStick
Copy link
Member

RayStick commented Jan 2, 2024

I think unit testing is a great idea (eventually)

@RayStick RayStick added help wanted Extra attention is needed and removed domain_mapping labels Apr 4, 2024
@RayStick RayStick assigned RayStick and unassigned BatoolMM Jul 23, 2024
@RayStick RayStick added this to the before rOpenSci milestone Jul 23, 2024
@RayStick RayStick removed the help wanted Extra attention is needed label Sep 6, 2024
@RayStick RayStick linked a pull request Sep 13, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or addition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants