From 227588c2a842660eae16322a07d33c5318d1f05e Mon Sep 17 00:00:00 2001 From: Phuc YNWA Date: Fri, 5 Jan 2024 16:39:11 +0700 Subject: [PATCH] Add compose Modifier parameter to PdfRendererViewCompose (#102) --- .../java/com/rajat/sample/pdfviewer/ComposeActivity.kt | 10 +++++++--- .../com/rajat/pdfviewer/compose/PdfRendererCompose.kt | 7 +++++-- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/rajat/sample/pdfviewer/ComposeActivity.kt b/app/src/main/java/com/rajat/sample/pdfviewer/ComposeActivity.kt index 0505e8f..9a608f4 100644 --- a/app/src/main/java/com/rajat/sample/pdfviewer/ComposeActivity.kt +++ b/app/src/main/java/com/rajat/sample/pdfviewer/ComposeActivity.kt @@ -33,7 +33,10 @@ class ComposeActivity : ComponentActivity() { modifier = Modifier.fillMaxSize(), color = MaterialTheme.colorScheme.background ) { - MyPdfScreenFromUrl(download_file_url2) + MyPdfScreenFromUrl( + url = download_file_url2, + modifier = Modifier.fillMaxSize() + ) } } } @@ -41,9 +44,10 @@ class ComposeActivity : ComponentActivity() { } @Composable -fun MyPdfScreenFromUrl(url: String) { +fun MyPdfScreenFromUrl(url: String, modifier: Modifier = Modifier) { val lifecycleOwner = LocalLifecycleOwner.current PdfRendererViewCompose( + modifier = modifier, url = url, lifecycleOwner = lifecycleOwner, statusCallBack = object : PdfRendererView.StatusCallBack { @@ -91,4 +95,4 @@ fun GreetingPreview() { AndroidpdfviewerTheme { MyPdfScreenFromUrl("https://css4.pub/2015/textbook/somatosensory.pdf") } -} \ No newline at end of file +} diff --git a/pdfViewer/src/main/java/com/rajat/pdfviewer/compose/PdfRendererCompose.kt b/pdfViewer/src/main/java/com/rajat/pdfviewer/compose/PdfRendererCompose.kt index dd0e8f7..f6d331b 100644 --- a/pdfViewer/src/main/java/com/rajat/pdfviewer/compose/PdfRendererCompose.kt +++ b/pdfViewer/src/main/java/com/rajat/pdfviewer/compose/PdfRendererCompose.kt @@ -1,6 +1,7 @@ package com.rajat.pdfviewer.compose import androidx.compose.runtime.Composable +import androidx.compose.ui.Modifier import androidx.compose.ui.platform.LocalLifecycleOwner import androidx.compose.ui.viewinterop.AndroidView import androidx.lifecycle.LifecycleOwner @@ -11,6 +12,7 @@ import java.io.File @Composable fun PdfRendererViewCompose( + modifier: Modifier = Modifier, url: String? = null, file: File? = null, headers: HeaderData = HeaderData(), @@ -34,6 +36,7 @@ fun PdfRendererViewCompose( }, update = { view -> // Update logic if needed - } + }, + modifier = modifier ) -} \ No newline at end of file +}