Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM may start selenoid container in different network than one of the browser containers #340

Open
matez0 opened this issue Oct 3, 2023 · 3 comments

Comments

@matez0
Copy link

matez0 commented Oct 3, 2023

If I see well, cm starts the selenoid container in a wired-in network selenoid:

networkName = "selenoid"

Network: networkName,

But at the same time it is possible to configure a different network for the browser containers with -container-network:

if !contains(cmd, "-container-network") {

How can the selenoid container work together with a browser container, if they are not in the same docker network?

Why the network of the selenoid container is not configurable?

@vania-pooh
Copy link
Member

@matez0 cm is a tool that just launches a Docker container with Selenoid in automated way and settings that are suitable for the majority of use cases. You can deliver the same installation manually with Docker Compose and a shell script. This is why network name is hard-coded. We don't have plans to make this configurable in CM.

@matez0
Copy link
Author

matez0 commented Oct 6, 2023

Even if the docker network is not planned to be configurable, the selenoid network should be set to the value given in the -container-network to have a usable system.
This would take not much effort to fix, would not?

@vania-pooh
Copy link
Member

@matez0 yes, that should be doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants