Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename podSpec to podTemplate and podDistruptionBudget to podDistruptionBudgetTemplate #110

Closed
Tracked by #109
kvaps opened this issue Apr 2, 2024 · 0 comments · Fixed by #118
Closed
Tracked by #109
Milestone

Comments

@kvaps
Copy link
Member

kvaps commented Apr 2, 2024

As part of #109

  • move podSpec.extraArgs to options
  • remove podSpec.extraEnvs, podSpec.resources, podSpec.image, podSpec.imagePullPolicy as they will be available to override in spec.podTemplate.spec.containers["etcd"] (see Add the ability to specify volumes and containers #113)
  • rename podSpec to podTemplate
  • rename podDistruptionBudget to podDistruptionBudgetTemplate
  • move all the parameters from podSpec.metadata to podTemplate.metadata
  • move all the parameters from podSpec to podTemplate.spec
---
apiVersion: etcd.aenix.io/v1alpha1
kind: EtcdCluster
metadata:
  name: test
  namespace: default
spec:
   replicas: 3
+  options: # map[string]string
+    arg1: "value1"
+    arg2: "value2"
-  podSpec:
-    image: "quay.io/coreos/etcd:v3.5.12"
-    imagePullPolicy: Always
-    extraArgs: # map[string]string
-      arg1: "value1"
-      arg2: "value2"
-    extraEnvs: # []core.v1.EnvVar Ready k8s type
-      - name: MY_ENV
-        value: "my-value"
+  podTemplate:
    metadata:
      labels:
        env: prod
      annotations:
        example.com/annotation: "true"
+    spec:
      imagePullSecrets:  # core.v1.LocalObjectReference Ready k8s type
      - name: myregistrykey
      serviceAccountName: default
-  podDistruptionBudget: {}
+  podDistruptionBudgetTemplate: {}
@kvaps kvaps changed the title Rename .spec.podSpec to pod and split to pod.spec and pod.metadata Rename .spec.podSpec to pod and split to template.spec and template.metadata Apr 3, 2024
@kvaps kvaps changed the title Rename .spec.podSpec to pod and split to template.spec and template.metadata Rename .spec.podSpec to template and split spec with metadata Apr 3, 2024
@kvaps kvaps changed the title Rename .spec.podSpec to template and split spec with metadata Rename .spec.podSpec to .spec.template and split spec with metadata Apr 3, 2024
@kvaps kvaps changed the title Rename .spec.podSpec to .spec.template and split spec with metadata Rename .spec.podSpec to .spec.template and split with metadata Apr 3, 2024
@kvaps kvaps changed the title Rename .spec.podSpec to .spec.template and split with metadata Rename podSpec to podTemplate and split spec with metadata Apr 3, 2024
@kvaps kvaps changed the title Rename podSpec to podTemplate and split spec with metadata Rename podSpec to podTemplate and podDistruptionBudget to podDistruptionBudgetTemplate Apr 3, 2024
@sircthulhu sircthulhu self-assigned this Apr 3, 2024
@kvaps kvaps added this to the v0.1.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants