Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen transition broken in 1.1.0-beta02 #444

Closed
griffinsorrentino opened this issue Jun 14, 2024 · 0 comments · Fixed by #445
Closed

Screen transition broken in 1.1.0-beta02 #444

griffinsorrentino opened this issue Jun 14, 2024 · 0 comments · Fixed by #445

Comments

@griffinsorrentino
Copy link
Contributor

During the work done in PR #428 (specifically this line https://github.com/adrielcafe/voyager/pull/428/files#diff-901900b91b64c9e8cecb5e415a8bb42f86e380394bbe003062925ffd6d30be2cR103), values set to a ContentTransforms targetContentZIndex and sizeTransform properties are removed. This is causing issues with backstack items showing overtop of items being removed.

There should be a check in place where these values are saved and passed along through the transition process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added targetContentZIndex and sizeTransform value passthrough
1 participant
@griffinsorrentino