Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Repository module of the mediator-coordination crate to a separate crate #162

Closed
2 tasks
Hermann-Core opened this issue Sep 9, 2024 · 1 comment · Fixed by #170
Closed
2 tasks
Assignees

Comments

@Hermann-Core
Copy link
Collaborator

Hermann-Core commented Sep 9, 2024

  • Since some dependencies will use the database for persisting data, it might be worth moving the Repository module in the mediator-coordination to a separate crate for flexibility and scalability.

  • I also noticed some unnecessary code duplication within the repository implementation. We could provide default implementations for the methods of the Repository trait. Since many implementations will likely use these defaults, this would reduce the need for re-implementations.

@IngridPuppet could you clarify where the forward messages are persisted in the mediator? I couldn’t find this part while reviewing the mediator-coordination code.

@Hermann-Core Hermann-Core self-assigned this Sep 9, 2024
@IngridPuppet
Copy link
Collaborator

@IngridPuppet could you clarify where the forward messages are persisted in the mediator? I couldn’t find this part while reviewing the mediator-coordination code.

This depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment