Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programmatically hiding messages broken #138

Open
ttill opened this issue Aug 8, 2019 · 9 comments
Open

Programmatically hiding messages broken #138

ttill opened this issue Aug 8, 2019 · 9 comments

Comments

@ttill
Copy link
Contributor

ttill commented Aug 8, 2019

In the past it was possible to manually remove open messages again (as documented in the readme) by doing message.set('visible', false);. This was broken in 436a3e5.

It would be great to have this feature back.
@btecu
Copy link
Member

btecu commented Aug 8, 2019

Can you do something like message.selfClose()?

ttill added a commit to ttill/ember-notify that referenced this issue Aug 9, 2019
@ttill
Fix hidden manually test.
078c6b9 
Did not actually test programmatically closing the message since it was
closed automatically at some point.

Test does fail now (see adopted-ember-addons#138).
@ttill ttill mentioned this issue Aug 9, 2019
Merged
@jameswmcnab
Copy link

Just came up against this issue, is this addon still maintained?

@btecu
Copy link
Member

btecu commented Mar 26, 2020

@jameswmcnab yes, I haven't had tried it yet but does message.selfClose() not work?

@ttill
Copy link
Contributor Author

ttill commented Mar 26, 2020

We do not have direct access to message. See #139.

@btecu
Copy link
Member

btecu commented Mar 26, 2020

@ttill While I don't think that's the cleanest approach, it would solve your need and @jameswmcnab. Can you get the tests to pass?

ttill added a commit to ttill/ember-notify that referenced this issue Mar 27, 2020
@ttill
Fix hidden manually test.
b9aa293 
Did not actually test programmatically closing the message since it was
closed automatically at some point.

Test does fail now (see adopted-ember-addons#138).
@ttill
Copy link
Contributor Author

ttill commented Mar 27, 2020

@btecu How would you propose to expose the close functionality?

By rebasing on master I was able to break the tests even more. Previously it only failed for some ember versions, now it fails for all of them. I do not understand how the errors would be related to my changes. Do you have any idea? Locally the tests pass. Thanks.

@btecu
Copy link
Member

btecu commented Mar 29, 2020 •
edited
Loading

@ttill I think we need to:

  • Update ember-cli to latest version
  • Fix lint & deprecations

I took a stab at this in #152 and I got it updated and fixed a few deprecations, but there are several left. Do you have some cycles to help?

@ttill
Copy link
Contributor Author

ttill commented Mar 30, 2020 •
edited
Loading

@btecu I will try to give it a shot later today

@ttill
Copy link
Contributor Author

ttill commented Apr 3, 2020

@btecu Sorry for the lack of response. I started working on this, but noticed that we would have to port all the tests to latest ember-mocha, which is quite a big task, as there are multiple breaking changes between versions. Cannot handle this at the moment. Sorry…

btecu pushed a commit that referenced this issue Aug 24, 2020
@ttill
Add close method for manually closing message (#139)
ddfe9c1 
* Fix hidden manually test.

Did not actually test programmatically closing the message since it was
closed automatically at some point.

Test does fail now (see #138).

* Add `close` method for manually closing message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ttill @jameswmcnab @btecu