Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P.hv function with outdated packages #4

Open
poniitty opened this issue Dec 5, 2021 · 3 comments
Open

P.hv function with outdated packages #4

poniitty opened this issue Dec 5, 2021 · 3 comments

Comments

@poniitty
Copy link

poniitty commented Dec 5, 2021

Thanks for a nice package.

Recent updates in spatstat and deldir packages seems to have messed up the P.hv function.

convexhull.xy seems to have shifted from spatstat to spatstat.geom package. This is easy to fix. I did not take closer look what the problem is with deldir.

Everything seems to be working when I downloaded older versions of the spatstat (1.64-1) and deldir (0.1-14) packages with devtools::install_version

Cheers,
Pekka

@jincazama
Copy link

Thanks for a nice package.

Recent updates in spatstat and deldir packages seems to have messed up the P.hv function.

convexhull.xy seems to have shifted from spatstat to spatstat.geom package. This is easy to fix. I did not take closer look what the problem is with deldir.

Everything seems to be working when I downloaded older versions of the spatstat (1.64-1) and deldir (0.1-14) packages with devtools::install_version

Cheers, Pekka

Hi poniitty, thanks for you suggestion.

Maybe, I meet a similar question with you. I try to download the older version of the spatstat (1.64-1) and deldir (0.1-14) packages, but it still have some error.

When i used the function P.hv() and chm() to test the example data, I got the error following
'Contradictory adjacency lists.
Error in deldir::deldir(x = xy[, 1], y = xy[, 2], z = canopy, rw = NULL, :
Bailing out of adjchk.' and 'Error: 'convexhull.xy' is not an exported object from 'namespace:spatstat'', respectively.

@poniitty
Copy link
Author

Hi JlnCazama,

I haven't used the package since the last December but it seems that there has not been any commits/changes after that in this Github repo.

Are you sure that you managed to install and download the older versions of the packages? Because for me it seems that the error message is indicating that you still use the later version of the spatstat where the convexhull.xy is not included anymore.

But let's hope that this gapfraction package will be still updated by the author.

Cheers,
-P-

@jincazama
Copy link

Thank you for you reply, poniitty!

I checked and found the version of package deldir is not 0.1-14 in my macOS, so i tried to reinstall the version of packages as you mentioned in windows. Fortunately, it works! In addition, compilation fail for deldir in macOS result from different CPU (M1, arm64), and some other packages cannot compiled to the latest version in arm64.

Hope you have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants