Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkHemisphering #144

Open
drserajames opened this issue Feb 8, 2023 · 0 comments
Open

checkHemisphering #144

drserajames opened this issue Feb 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@drserajames
Copy link
Member

checkHemisphering doesn't work for 3D maps, is fine for 2D maps. Typo on line 72 as below.

library(Racmacs)
packageVersion("Racmacs")
[1] ‘1.1.38’

set.seed(123)
dat <- matrix(102^round(10runif(100)), ncol=10)
set.seed(456)
map <- make.acmap(dat, verbose=F, options=list(report_progress = F), number_of_dimensions = 3)

ch <- checkHemisphering(map)
R(56515,0x11b889e00) malloc: *** error for object 0x7f815c472f60: pointer being freed was not allocated
R(56515,0x11b889e00) malloc: *** set a breakpoint in malloc_error_break to debug
zsh: abort R

src/ac_hemi_test.cpp
Line 72:
hemi_ag_improved_coords(3) = grid_results.zcoords( sub(2) );
should be
Line 72:
hemi_ag_improved_coords(2) = grid_results.zcoords( sub(2) );

@drserajames drserajames added the bug Something isn't working label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant