Refactor random.jl in generator/formula.jl and generator/random.jl #31
+915
−681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… randatom moved from utils.jl to generation/formula.jl
…w the first type)
…ifference between the two is a fallback to a default seed. Not working at the moment.
…hanges; @Assert to throw(ErrorType(msg))
…(in the previous commit, @Assert where removed in favour of throw(ErrorType(msg)))
…spatch); sample dispatches and docstrings tied up
…al -> }=val in kwargs, one-line comments now does start with lower case
…jl; random.jl removed (all its content is in generation/formula.jl and generation/models.jl)
…is still not used)
|
I found an old TODO and I resolved it (partially): now, When a non-finite alphabet is given to |
…ith Base.rand. Now, tests/random.jl is splitted in tests/generator/formula.jl and tests/generator/models.jl
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #31 +/- ##
==========================================
+ Coverage 53.05% 54.29% +1.24%
==========================================
Files 43 45 +2
Lines 2980 2978 -2
==========================================
+ Hits 1581 1617 +36
+ Misses 1399 1361 -38 ☔ View full report in Codecov by Sentry. |
…cs.jl, before both generation/formula.jl and generation/models.jl
… to @__rng_dispatch). New docstrings in src/generation. new tests for `randframe` and `randmodel`
…` are of type Operator). `operators` type is already specified in function signature
…e seed and height.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust docstrings, separate formula and model generations, add more robust tests