Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Migrate Shodan unit testing framework to pytest #218

Open
rmhowe425 opened this issue Jul 14, 2024 · 1 comment
Open

TST: Migrate Shodan unit testing framework to pytest #218

rmhowe425 opened this issue Jul 14, 2024 · 1 comment

Comments

@rmhowe425
Copy link
Contributor

I am recommending that the existing unit tests be migrated away from the unittest library over to pytest.

Benefits:

  • Leverage PyTest fixtures as a cleaner and simpler solution for unit testing setUp / tearDown functionality.
  • pytest.mark.parameterize provides a much cleaner, simpler, and scalable method to handle multiple test cases when testing a single method.
  • Easier to scope tests down to a single function, rather than testing at the class level.
  • Leverage PyTest fixtures + mock requests to test HTTP requests.
@rmhowe425
Copy link
Contributor Author

@achillean I'm also requesting your feedback on whether you're cool with me adding additional unit tests for this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant