Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add scans metadata validation #127

Open
jeffersoncasimir opened this issue Jun 5, 2024 · 5 comments
Open

[feature] Add scans metadata validation #127

jeffersoncasimir opened this issue Jun 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers queue

Comments

@jeffersoncasimir
Copy link
Collaborator

jeffersoncasimir commented Jun 5, 2024

It would be valuable to verify the completeness of the _scans.tsv.

There should be one file per session, with one entry for every recording.

The user should be notified of missing entries or invalid fields.

@harsha-mangena
Copy link

Hey @jeffersoncasimir, Can I work on this issue?

@jeffersoncasimir
Copy link
Collaborator Author

Hey @jeffersoncasimir, Can I work on this issue?

Hello @harsha-mangena , unfortunately this issue is already earmarked for a current participant's project. Sorry about that.

@harsha-mangena
Copy link

@jeffersoncasimir, Thank you for the response.

@christinerogers
Copy link
Collaborator

christinerogers commented Jun 5, 2024

  • ifit's not implemented then get code from HBCD @laemtl : assume acquisition date from first Event first date could be inserted (hbcd takes the timestamp from first event)
    if assume from Events file --> make this a very clear warning message

if that's not possible print a strong warning anyway

  • strong warning at a minimum -> it's valid so this won't be a blocking Error

@christinerogers
Copy link
Collaborator

christinerogers commented Sep 13, 2024

for another issue;

  • coded date could be marked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers queue
Projects
None yet
Development

No branches or pull requests

4 participants