Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP version number overlaps search bar #153

Closed
Michael-Grover opened this issue Oct 9, 2019 · 7 comments
Closed

AP version number overlaps search bar #153

Michael-Grover opened this issue Oct 9, 2019 · 7 comments
Assignees
Labels
A11Y 🔓 Accessibility related Difficulty: Starter Good First Issue :octocat: Good for newcomers hacktoberfest by DigitalOcean and DEV Type: Bug 🐛 Something isn't working

Comments

@Michael-Grover
Copy link
Contributor

Describe the bug
In the nav bar, the Accord Project logo and version number overlaps the search bar on narrow screen widths (mobile)

To Reproduce
Steps to reproduce the behavior:

  1. Go to docs.accordproject.org on a mobile device, or reduce your window screen width to below 500px

Expected behavior
We expect the search bar to be accessible at all screen widths.

Suggested fix
At screen widths less than 600px, remove the "ACCORD PROJECT" Text from the Accord Project logo so that just the icon is there.

Set the Alt text to "Return to docs.accordproject.org homepage"

Accord-Project-logo-small.svg.zip

Screenshots
image

@Michael-Grover Michael-Grover added Type: Bug 🐛 Something isn't working Good First Issue :octocat: Good for newcomers A11Y 🔓 Accessibility related Difficulty: Starter labels Oct 9, 2019
@jolanglinais jolanglinais added the hacktoberfest by DigitalOcean and DEV label Oct 9, 2019
@shahsank3t
Copy link
Contributor

Is someone working on this issue? Else I would like to start on it

@Michael-Grover
Copy link
Contributor Author

@shahsank3t no one is currently working on this issue. Feel free to take it.

Thanks!

@jeromesimeon
Copy link
Member

jeromesimeon commented Oct 9, 2019

@shahsank3t I think this might be a Docusaurus issue. I would see if this has been fixed in more recent versions before doing anything on the source in this repo. One possibly related issue is facebook/docusaurus#1697

@jeromesimeon
Copy link
Member

@shahsank3t I think this might be a Docusaurus issue. I would see if this has been fixed in more recent versions before doing anything on the source in this repo. One possibly related issue is facebook/docusaurus#1697

Maybe I'm wrong, since we're using an image...

@shahsank3t
Copy link
Contributor

@jeromesimeon - Yes, since we are using an image (logo + text) we are running into this issue. Instead if similar to what Docusaurus does, if we using the small logo and the text separately, Docusaurus will take care of hiding the text when screen size gets smaller.

@shahsank3t
Copy link
Contributor

@Michael-Grover @jeromesimeon - Created PR - #158

@jolanglinais
Copy link
Member

@Michael-Grover this is closed, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11Y 🔓 Accessibility related Difficulty: Starter Good First Issue :octocat: Good for newcomers hacktoberfest by DigitalOcean and DEV Type: Bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants