Handle termination HTTP signal #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a method of remotely terminating the proxy. See Issue abutaha#77
Probably don't want to add the ability to remotely shutdown the proxy to be accessible unless desired and in a safe environment, so moving behind a flag. Also updated the README with latest usage. See Issue abutaha#77
amcintosh
force-pushed
the
post-to-terminate
branch
from
33f25d5
to
0735035
Compare
|
Hi, Cool feature! Will have it merged soon. Thanks, |
|
Thanks! |
minichate
approved these changes
Aug 10, 2020
| @@ -24,4 +24,5 @@ https://github.com/diranged | |||
| https://github.com/em0ney | |||
| https://github.com/zqben402 | |||
| https://github.com/dlackty | |||
| https://github.com/amcintosh | |||
| @@ -210,6 +212,10 @@ func (p *proxy) getSigner() *v4.Signer { | |||
| } | |||
|
|
|||
| func (p *proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| if p.remoteTerminate && r.URL.Path == "/terminate-proxy" && r.Method == http.MethodPost { | |||
| logrus.Infoln("Terminate Signal") | |||
| os.Exit(0) | |||
| @@ -210,6 +212,10 @@ func (p *proxy) getSigner() *v4.Signer { | |||
| } | |||
|
|
|||
| func (p *proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| if p.remoteTerminate && r.URL.Path == "/terminate-proxy" && r.Method == http.MethodPost { | |||
There was a problem hiding this comment.
I didn't want to terminate on a GET and while I considered DELETE, this isn't exactly restful, so I figured POST to be the most intuitive.
|
Hi @abutaha. Do you know when you'll be able to merge this? Thanks! |
minichate
approved these changes
Sep 8, 2020
phntom
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
i would like this change merged. @amcintosh do you have a docker hub fork of this built?
|
@phntom I do not at the moment. |
|
Apologies for the delay. I'll merge this ASAP.
…On Tue, Oct 6, 2020, 20:22 Andrew McIntosh ***@***.***> wrote:
@phntom <https://github.com/phntom> I do not at the moment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJD57X6P54PTGDZMFKNE3SJM76FANCNFSM4PQXLLAQ>
.
|
|
i've deployed your branch under phntom/aws-es-proxy:0.9.1 but i'll switch when an official release is available, seems to be working well with python requests.post to the url. |
|
@abutaha Any chance you get this released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a method of remotely terminating the proxy.
See Issue #77