Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OSX #58

Open
AlexGKim opened this issue Jul 21, 2022 · 3 comments
Open

Add support for OSX #58

AlexGKim opened this issue Jul 21, 2022 · 3 comments

Comments

@AlexGKim
Copy link

It seems that os.sched_getaffinitycalled in the enclosed link is not supported by OSX. Or at least it doesn't work on my laptop.

I am running Python 3.8.8

DEFAULT_BLOSC_THREADS = max(1, min(len(os.sched_getaffinity(0)), DEFAULT_BLOSC_THREADS))

@lgarrison
Copy link
Member

Thanks for the report! I haven't done any testing on OSX; this bug is easy enough to fix, but I have no clue if the rest of the code is OSX-safe. I'll add a CI config so we can find out.

@lgarrison
Copy link
Member

@AlexGKim Unfortunately the tests don't pass on OSX, even after fixing the bug you reported (https://github.com/abacusorg/abacusutils/runs/7471117270?check_suite_focus=true). I don't have an OSX platform to debug on, so for now I don't think we'll be able to support OSX. But if you're feeling motivated to dig into this issue, we would welcome the contribution and I'd be happy to advise your debugging!

I'm also going to rename the issue to reflect the current state of the problem.

@lgarrison lgarrison changed the title module 'os' has no attribute 'sched_getaffinity' Add support for OSX Jul 22, 2022
@AlexGKim
Copy link
Author

Hi @lgarrison . I had code that only had to be run once that got run on a UNIX machine. So my personal issue is solved. I will dig more deeply into this if the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants