Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event parsing lacks content & organizer #56

Closed
Ruxton opened this issue Aug 24, 2018 · 6 comments
Closed

Event parsing lacks content & organizer #56

Ruxton opened this issue Aug 24, 2018 · 6 comments

Comments

@Ruxton
Copy link

Ruxton commented Aug 24, 2018

Parsing this event http://tantek.com/2018/234/e1/homebrew-website-club-sf lead to some issues in the timeline response:

  • content was missing, though summary was present
  • organizer was missing
  • author missing, in the single page author is present, in the homepage the entire h-feed is parented by a h-card, so I would assume if the individual event didn't have an explicit author on the homepage, it should inherit the parent h-card?

It's worth noting that the parse obviously happened using the h-feed from http://tantek.com and not the individual post. Just linked the original post so you knew where to find it.

@Ruxton
Copy link
Author

Ruxton commented Aug 24, 2018

This all boils down to https://github.com/swentel/indigenous-android rendering the event as such:
screenshot_20180824-115532

@Ruxton
Copy link
Author

Ruxton commented Aug 24, 2018

The event item in the aperture microsub response:

        {
            "type": "event",
            "name": "Homebrew Website Club SF!",
            "summary": "17:30: Optional writing hour and quiet socializing\n18:30: IndieWeb demos and hack night!\n\nHomebrew Website Club retro 1980s-style logo\nTopics for this week: Summer of IndieWeb! What IndieWeb projects are you hacking on this summer? 2018-09-22…23 The First IndieWebCamp Oxford! 2018-09-28…29 IndieWebCamp NYC is back for 2018 and bigger than ever!\nDemos of personal website breakthroughs. Create or update your personal web site!\nJoin a community with like-minded interests. Bring friends that want a personal site, or are interested in a healthy, independent web!\nAny questions? Ask in #indieweb Slack or IRC\nMore information: IndieWeb Wiki Event Page\nRSVP: post an indie RSVP on your own site!",
            "published": "2018-08-21 20:25-0700",
            "start": "2018-08-22 17:30-0700",
            "end": "2018-08-22 19:30-0700",
            "url": "http://tantek.com/2018/234/e1/homebrew-website-club-sf",
            "location": [
                "https://wiki.mozilla.org/SF"
            ],
            "post-type": "event",
            "refs": {
                "https://wiki.mozilla.org/SF": {
                    "type": "card",
                    "name": "Mozilla San Francisco",
                    "url": "https://wiki.mozilla.org/SF",
                    "photo": null
                }
            },
            "_id": "839580",
            "_is_read": true
        }

@aaronpk
Copy link
Owner

aaronpk commented Aug 24, 2018

Looks like tantek has already started publishing content for events instead of description. I need to update XRay to look for that. See discussion on microformats parsing: microformats/h-event#3

@aaronpk
Copy link
Owner

aaronpk commented Aug 24, 2018

aaronpk/XRay#75

@aaronpk
Copy link
Owner

aaronpk commented Aug 24, 2018

Interesting, I don't see any reference to "author" on http://microformats.org/wiki/h-event

I suppose it makes sense to also return the author of an event. Some discussion on the vocabulary: microformats/h-event#2 (comment)

aaronpk added a commit to aaronpk/XRay that referenced this issue Oct 13, 2019
@aaronpk
Copy link
Owner

aaronpk commented Oct 13, 2019

XRay now returns author information for events, so these posts should show up better now. The organizer property is still experimental/proposed in h-event, so I'm going to hold off on doing anything with that now, especially since there's no clear mapping to that in the current UI of readers.

@aaronpk aaronpk closed this as completed Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants