Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR testing not setup #12

Open
moriarty opened this issue Oct 22, 2019 · 1 comment
Open

PR testing not setup #12

moriarty opened this issue Oct 22, 2019 · 1 comment

Comments

@moriarty
Copy link
Contributor

@cjds and @erelson I just opened #16 and noticed I must have forgotten to setup PR testing on this repo- sorry.

It is setup on other PRs for example: ZebraDevs/fetch_robots#57

Similar to: ZebraDevs/fetch_msgs#17
@moriarty
Copy link
Contributor Author

Also @cjds you may want to look into #7 again, as we had talked about this before I left the standard msg which wasn't available at the time has grown to be nearly a superset of the our power_msgs and I had spoken with @dbking77 because I think the new standard one could used instead of the internal msgs which would save some headaches between commercial and research code.

I thought it would take only a little effort, but it should definitely be done before any ROS2 transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moriarty