Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(deps): Enable a tinyvec feature to speed up compilation #4796

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

teor2345
Copy link
Collaborator

@teor2345 teor2345 commented Jul 20, 2022

Motivation

Enable a feature in tinyvec that speeds up compilation by about half a second per crate. It also speeds up compilation in any dependencies of that crate.

This could make Zebra builds a few seconds faster.

Lokathor/tinyvec#161

Review

This is a low priority fix.

Reviewer Checklist

  • Tests pass

@teor2345 teor2345 added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ labels Jul 20, 2022
@teor2345 teor2345 requested review from a team as code owners July 20, 2022 03:21
@teor2345 teor2345 self-assigned this Jul 20, 2022
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team July 20, 2022 03:21
@teor2345 teor2345 changed the title change(deps): Use a transitive dependency feature to speed up compilation change(deps): Enable a crate feature to speed up compilation Jul 20, 2022
@teor2345 teor2345 changed the title change(deps): Enable a crate feature to speed up compilation change(deps): Enable a tinyvec feature to speed up compilation Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #4796 (9ce6608) into main (69751e9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4796      +/-   ##
==========================================
- Coverage   78.72%   78.72%   -0.01%     
==========================================
  Files         309      309              
  Lines       38776    38776              
==========================================
- Hits        30528    30527       -1     
- Misses       8248     8249       +1     

conradoplg
conradoplg previously approved these changes Jul 20, 2022
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy performance gains are always welcome 😁

dconnolly
dconnolly previously approved these changes Aug 1, 2022
@teor2345
Copy link
Collaborator Author

teor2345 commented Aug 3, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2022

update

☑️ Nothing to do

  • -closed [:pushpin: update requirement]
  • #commits-behind>0 [:pushpin: update requirement]

@teor2345 teor2345 requested a review from dconnolly August 3, 2022 15:36
mergify bot added a commit that referenced this pull request Aug 3, 2022
@mergify mergify bot merged commit 42f6c27 into main Aug 3, 2022
@mergify mergify bot deleted the compile-speed branch August 3, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants