Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is obscured at page breaks when printed #352

Open
dmgirard opened this issue Jan 30, 2021 · 19 comments
Open

Text is obscured at page breaks when printed #352

dmgirard opened this issue Jan 30, 2021 · 19 comments

Comments

@dmgirard
Copy link

Describe the bug
Text is obscured at page breaks when the adjusted web page is printed in Google Chrome.

To Reproduce
Steps to reproduce the behavior:

  1. Go to: https://www.psychologytoday.com/us/blog/the-right-mindset/202011/new-research-finds-pessimism-signals-bipolar-relapse?amp
  2. Click on 'Just Read'
  3. Click on 'Print article' button
  4. Scroll to last page of article on Print Preview.
  5. Notice text obscured by page break.

Expected behavior
I expect that all text in the article will be clearly legible when I go to print the article.

Screenshots
Screenshot 2021-01-29 21_01_31

Please complete the following information:

  • OS: Microsoft Windows 10
  • Browser: Google Chrome
  • Version: Version 88.0.4324.104 (Official Build) (64-bit)

Additional context
None

@dmgirard dmgirard added the bug label Jan 30, 2021
@ZachSaucier
Copy link
Owner

Hmm. I'm not able to reproduce this issue. Using Chrome on Windows, same build.

Are you using the default stylesheet?

@dmgirard
Copy link
Author

Yes. Just to be sure, I uninstalled the extension, reinstalled it, restarted the browser, and tried again. Same issue. I'm getting a ton of errors on this page when I click on 'Just Read.' See below. I don't know if that's relevant.

Screenshot_2021-01-29 21_45_50

@ZachSaucier
Copy link
Owner

I'll try to test on another computer when I can but no promises on a fix.

You can try adjusting the margins as a workaround.

Those errors are not related to Just Read FYI.

@dmgirard
Copy link
Author

dmgirard commented Feb 1, 2021

Thanks. The problem occurs with the "Default" margin setting. When using custom margins (0.5" on top and bottom), the problem goes away.

If I toggle the Headers/Footers setting, you can see what is happening more clearly. See the two images below.

Image 1 (Headers and Footers enabled):

2021-02-01 09_41_59-14 Proven Responses to the Most Frustrating Backtalk _ Empowering Parents

Image 2 (Headers and Footers disabled):

2021-02-01 09_42_12-14 Proven Responses to the Most Frustrating Backtalk _ Empowering Parents

@SaschaBur
Copy link

Same problem here on MAcOs Chrome. JustREad is GREAT, but this prevents me often from using it as i loose whole lines in the printout on PDF.

@ZachSaucier
Copy link
Owner

I still can't reproduce this issue. If you're able to help me reproduce it that'd be appreciated. Or if you edit the stylesheet to fix the issue, that'd be even better!

It's the same sort of issue as #51 which has been fixed (at least on my devices).

@Jillnvc
Copy link

Jillnvc commented Feb 17, 2021

I'm having this issue too and it's really frustrating that I didn't have it on the free version. I was better off not paying. I really liked Just Read and wanted to support it.

I've tried every combination of margins and scale and it still cuts lines off at the top and bottom. (MacOS, Chrome). If I can fix it for the first page, it will cut off on later pages.

@ZachSaucier
Copy link
Owner

I didn't have it on the free version

The free and paid versions are the exact same in this way. So it can't be an issue with you having Premium.

@Jillnvc Can you please share what URL you are trying to print?

@Jillnvc
Copy link

Jillnvc commented Feb 18, 2021

It happens for me with nearly every url. Here is the latest: https://austinchanning.substack.com/p/dear-nice-white-people

If you can't reproduce it with that, let me know and I'll post more.

@ZachSaucier
Copy link
Owner

I cannot reproduce the issue. But you do not need to share more pages.

The issue must be due to some configuration or environmental setting. Given I can't reproduce the issue on any of the linked pages, it might be some time before someone posts enough info to where I can reproduce it in order to figure out a solution.

@Jillnvc
Copy link

Jillnvc commented Feb 18, 2021

Are you able to test it on a Mac with Chrome? If you can tell me what type of information I can offer, I will do it.

@ZachSaucier
Copy link
Owner

Are you able to test it on a Mac with Chrome?

Yep. On Catalina. No issues.

If you can tell me what type of information I can offer, I will do it.

Sorry, but I don't know what info might be relevant at this point.

@Jillnvc
Copy link

Jillnvc commented Apr 15, 2021

I'm still trying to figure this out. When I select the print command from within Just Read, it always resets to the default margins of 0. I can even print to PDF and then print to my printer and it will reset the default margins. And then, seemingly randomly, it will save my custom margins for the next thing, or maybe not. I need to change the default margins in the print settings. Is that part of Just Read or Chrome?

@ZachSaucier
Copy link
Owner

ZachSaucier commented Apr 15, 2021

You can view the styles that Just Read adds for printing here. You can override them in your personal theme stylesheets as needed. Anything else would be in your browser's print settings.

@oep42
Copy link

oep42 commented May 17, 2021

Same problem here. The problem occurs with every Chromium browser I have tried.

Just Read 5.1.2
Windows 8.1
Browsers:
--- Vivaldi 3.6.2165.40 (32-bit)
--- Slimjet 29.0.2.0 (32-bit)
--- Torch 69.2.0.1713 (32-bit)

The problem does not occur in the Firefox version of the extension.

@crogonint
Copy link

crogonint commented Jul 27, 2023

Hey Zach, ,this is James, I posted on the Chrome store about the issue..

I think what we are seeing is that Just Read is grabbing the page footer or lower margin from the original document and using it as a default for the printed output.. somehow. I've noticed it doing it on web pages that use frames, and I THINK that that's what is going on.

Again, I totally blame Chrome, because Chrome's print driver OUGHT to know better than to hide text or content behind an empty margin! That said.. the footer/lower margin is useless anyway. I honestly don't know HOW many documents I saved before I noticed. I was so tickled with the "pretty print' style document in Just Read, that I never bothered checking that it was working in the Chrome print to PDF window.

EDIT: I'm not happy with PrintFriendly, so I'm going to re-install Just Read and see if I can't do something reproducible for you. :)

@crogonint
Copy link

Well.. I've discovered that virtually no text from Github makes it in to Just Read. I've discovered that Reddit imports a pile of form columns in to Just Read and makes a bit of a mess of it. I've also discovered that the websites I seem to recall having issues with previously.. all appear to be working correctly right now. :/ Did you fix something??

I'll continue using Just Read for the time being, and report back when I find the websites that I was having problems with previously. :)

@ZachSaucier
Copy link
Owner

I think what we are seeing is that Just Read is grabbing the page footer or lower margin from the original document and using it as a default for the printed output.. somehow

Hmm. I bring all the content into an iframe so I wouldn't think that would be an issue. But if you are able to test something and find this to be the case let me know!

I've noticed it doing it on web pages that use frames, and I THINK that that's what is going on.

What do you mean by this?

I've also discovered that the websites I seem to recall having issues with previously.. all appear to be working correctly right now. :/ Did you fix something??

If you mean from this morning to now, no 🙂

@crogonint
Copy link

For some reason, I never got a notice of your reply.. or I missed it.

If I recall, the problem appeared that Just Read was importing some sort of formatting from pages that use frames, and forwarding that to the Chrome Print window. I can't recall if it was margins or paragraph spacing or what, but I seem to recall that SOMETHING was making it past the Just Read window in to the Print window, and THAT was mucking up the margins and allowing text to get hidden behind the print margin.

Again again, I totally blame Chrome, because their print driver OUGHT to know better than to hide text!

I had been using Just Read and Print to PDF to save various wiki style articles for future reference. They pretty much ALL got hosed due to this issue, but when I went back to try them again, it was working properly.

The takeaway is that I noticed that Reddit and Github itself gave Just Read a nervous breakdown, as described above. I think if you concentrate on forcing those to pretty print correctly, you might come across the troublesome bit of code that is getting imported in to the CHrome Print window and causing all of the issues. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants