Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate main view to SwiftUI #113

Merged
merged 75 commits into from
Sep 20, 2023
Merged

Migrate main view to SwiftUI #113

merged 75 commits into from
Sep 20, 2023

Conversation

jensutbult
Copy link
Contributor

No description provided.

@jensutbult jensutbult force-pushed the jens/swiftui branch 2 times, most recently from 90e5a00 to 09f5486 Compare April 21, 2023 09:07
@jensutbult jensutbult force-pushed the jens/swiftui branch 4 times, most recently from 60353fe to 8fd2281 Compare May 24, 2023 08:33
@jensutbult
Basic SwiftUI account list.
74c2dc0
@jensutbult
Dropped the idea of reusing the old OATHViewModel and started rewriti…
5474870 
…ng it in a more SwiftUI-friendly way.

Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Fixed broken logic for setting title and subtitle of an Account.
facbc6e 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Calculate accounts with non default period correctly.
346e890 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Account model sends refresh when it needs to be re-calculated.
1de3052 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Only refresh when connection is wired. Prepared for refreshing indivi…
9c921b1 
…dual Accounts.

Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Update code if Account already exists instead of always creating a ne…
eb7af3c 
…w Account.

Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Removed commented out code.
67fe5e8 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Do not animate going from 0 to 1 progress in pie view.
24a521d 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Proper observation of state changes in AccountDetailsView.
9cc519d 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
AccountRowView holds on to Account a little to long and does not rele…
64e2986 
…ase the object until the List is refreshed. This has been verified with a sample project and this kludge seems to be the only way of solving it.

Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Added requires touch and calculate status icons.
0045b74 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Code and status icon on same line and proper horizontal alignement.
50e228d 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Show title and subtitle in details view.
bba9faa 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Rudimentary menu in account details view and calculate of individual …
70280d3 
…accounts.

Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Enable/disable calculate and copy in account details menu.
26ced10 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Better animation timing.
1016d90 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Configuration hooked into the SwiftUI menu.
6428a8a 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
About view hooked up in menu.
b6c66f4 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Hooked up add account and some UI polish to navigation bars.
3be906a 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Delete account hooked up.
a3187f5 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Bumped version to 1.7.2 and added ITSAppUsesNonExemptEncryption key t…
b21b59f 
…o Info.plist.

Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Implemented rename account.
9f1f2ea 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Only show rename account if key supports it.
6e0a181 
Signed-off-by: Jens Utbult <[email protected]>
@jensutbult
Copy-on-long-press for accounts that requires NFC scan.
1cd3073
@jensutbult
Cleaned up the code regarding credential state and how we handle tran…
97979a9 
…sitions from one state to another. Also fixes several bugs where state would be messed up.
@jensutbult
Added whats new button to swiftui main view.
82d29ae
@jensutbult
Show touch yubikey toast.
6c9ca08
@jensutbult
Use toast when copying otp in details view.
aa6c1be
@jensutbult
Improved colors and animation of the otp code.
ab3047c
@jensutbult
HOTP AccountRowViews are grayed out until they have been calculated.
866e226
@jensutbult
PIV extension module implemented in SwiftUI.
868c2b0
@jensutbult
Fix bug where connections would fail in PIV-extension if app was star…
3a8e727 
…ted from scratch by the notification.
@jensutbult
Only copy YubiOTP when the corresponding setting is set to true.
24611fb
@jensutbult
Disable "Add account" amd "Configuration" in menu for iPads if no key…
d818bbe 
… is plugged in.
@jensutbult
Make sure we present the app in single view on iPad.
12e94b9
@jensutbult
Disable pull-to-refresh on iPad.
51a4de2
@jensutbult
Handle duplicate accounts when adding new account to key.
f4c35a5
@jensutbult
Show dismiss NFC modal hint.
e8bd00f
@jensutbult
Handle pinning when renaming an account.
797389e
@jensutbult
Deleted old UIKit files.
5db8e92
@jensutbult
Fixed issue that disabled animations in main view.
3406f0d
@jensutbult
Bumped build number and version.
5b59143
@jensutbult
Dismiss any views presented on top of MainView when the PIVTokenView …
adc1c07 
…is about to be presented.
@jensutbult
Animation tweaks.
c965a8e
@jensutbult
Removed debug print.
5fd714b
@jensutbult
Fixed copyright text.
a5a7171
@jensutbult
Fixes crash on iPad and adjusts menu in details view. Draft change log.
92d37aa
@jensutbult
Password save dialog now displays correctly on iPad.
996f384
@jensutbult
Remove non-functioning passcode to store accesskeys for devices with …
39c5f40 
…no biometric setup.
@jensutbult jensutbult marked this pull request as ready for review September 19, 2023 13:31
@jensutbult jensutbult merged commit 0556509 into main Sep 20, 2023
1 check failed
@jensutbult jensutbult deleted the jens/swiftui branch September 20, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson dainnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jensutbult @dainnilsson